Changes between Version 3 and Version 4 of Ticket #2427, comment 12


Ignore:
Timestamp:
2015-06-03T22:05:20Z (9 years ago)
Author:
daira
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2427, comment 12

    v3 v4  
    1 Remember that we removed the `autoAdd=True` argument from the initial call to `watch`, in [https://github.com/david415/tahoe-lafs/commit/e57645a9f15a7223eb33984cdd495a55b246e474]. We did this because we believed that adding the extra explicit call to `watch` in `_add_dir` ([https://github.com/david415/tahoe-lafs/commit/e57645a9f15a7223eb33984cdd495a55b246e474#diff-d8c61dbeca89240ad731932115de07d7R185 here]) was the correct way to handle directories being moved into the monitored directory tree, since we had found that `autoAdd` does not add a watch in that case.
     1Remember that we removed the `autoAdd=True` argument from the initial call to `watch`, in [https://github.com/david415/tahoe-lafs/commit/e57645a9f15a7223eb33984cdd495a55b246e474]. We did this because we believed that adding the extra explicit call to `watch` in `_add_dir` ([https://github.com/david415/tahoe-lafs/commit/e57645a9f15a7223eb33984cdd495a55b246e474#diff-d8c61dbeca89240ad731932115de07d7R185 here]) was the correct way to handle directories being moved into the monitored directory tree, since we had found that `autoAdd` does not implicitly add a watch in that case.
    22
    33It's likely that the problem is in that code; I would suggest adding a `print` to make sure that `watch` is being called for the moved-in directory, and with the correct arguments.