#2393 closed defect (fixed)
name OS-X .pkg after the tahoe version
| Reported by: | warner | Owned by: | warner |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.10.1 |
| Component: | packaging | Version: | 1.10.0 |
| Keywords: | easy osx packaging Makefile | Cc: | |
| Launchpad Bug: |
Description
At present, the make build-osx-pkg always creates the same file: tahoe-lafs-osx.pkg. This is being uploaded to org, but because it always uses the same filename, it will overwrite the previous file each time.
We should change the build step to ask Tahoe for a version string, and incorporate that into the package name. Maybe tahoe-lafs-VERSION.osx.pkg ?
Change History (6)
comment:1 Changed at 2015-03-21T17:34:46Z by daira
- Keywords easy osx packaging Makefile added
- Milestone changed from soon to 1.10.1
- Owner set to daira
- Status changed from new to assigned
comment:2 Changed at 2015-03-21T21:21:26Z by warner
- Keywords review-needed added
https://github.com/tahoe-lafs/tahoe-lafs/pull/146 is ready for review
comment:3 Changed at 2015-03-24T16:14:19Z by daira
Reviewed and merged in [610ba0e69ba430002680829b43f2c098c94d6b9c/trunk]. See this comment for a minor remaining issue.
comment:4 Changed at 2015-03-24T16:17:17Z by daira
- Keywords review-needed removed
- Owner changed from daira to warner
- Status changed from assigned to new
comment:5 Changed at 2015-03-24T17:05:28Z by warner
- Resolution set to fixed
- Status changed from new to closed
I see you moved the version-computation down into build-osx-pkg.py, sounds fine to me. In the long run (after 1.10.1, when we add Versioneer, for which I can't seem to find a ticket), the version will be computed with python setup.py version, instead of slicing+dicing the pre-generated _version.py. But that command can be run equally well from the Makefile or from build-osx-pkg.py.
comment:6 Changed at 2015-03-24T17:27:16Z by daira
Yes, I addressed that comment in [61f3d5ae1343836e76901a36db1c93541cd66251/trunk].
Let's use tahoe-lafs-VERSION-osx.pkg. The Makefile entry already computes the version number (using sh -c "cat src/allmydata/_version.py | grep verstr | head -n 1 | cut -d' ' -f 3"), so this should be easy.