Opened at 2013-10-09T11:13:59Z
Last modified at 2013-10-11T14:39:18Z
#2092 closed defect
the src/allmydata_tahoe.egg-info directory shouldn't be included in sdist tarballs — at Version 6
| Reported by: | bertagaz | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.10.1 |
| Component: | packaging | Version: | 1.10.0 |
| Keywords: | release packaging sdist setuptools Makefile reviewed | Cc: | |
| Launchpad Bug: |
Description (last modified by daira)
When running make clean, the process removes the src/allmydata_tahoe.egg-info directory. This directory is distributed within Tahoe-LAFS sources, which is inconsistent with the fact that make clean should only reset the Tahoe-LAFS directory to a freshly uncompressed state.
This doesn't help in packaging Tahoe-LAFS in distributions like Debian, where tools usually run a make clean before attempting to build. They fail after this first clean, because they detected this directory was removed but is part of the release tarball.
So either make clean shouldn't take care of this directory, or it has to be removed from the release tarball.
Change History (6)
comment:1 Changed at 2013-10-09T11:15:24Z by bertagaz
- Summary changed from ,'make clean' shouldn't remove the src/allmydata_tahoe.egg-info directory to 'make clean' shouldn't remove the src/allmydata_tahoe.egg-info directory
comment:2 Changed at 2013-10-10T01:55:13Z by zooko
comment:3 Changed at 2013-10-10T01:55:24Z by zooko
- Keywords review-needed added
comment:4 Changed at 2013-10-10T12:57:11Z by daira
- Keywords review-needed removed
src/allmydata_tahoe.egg-info is a generated directory that doesn't exist in the checked-in source. Removing review-needed so that this doesn't get committed before I've checked whether this directory should exist in tarballs.
comment:5 Changed at 2013-10-10T13:13:12Z by daira
- Keywords packaging sdist setuptools added; easy removed
- Milestone changed from undecided to 1.11.0
- Priority changed from normal to major
A tarball with src/allmydata_tahoe.egg-info removed builds fine and passes tests. So I conclude that this directory should not be in future sdist tarballs. Note that it is standard behaviour of python setup.py sdist to include it, but that is probably a bug in setuptools/zetuptoolz.
comment:6 Changed at 2013-10-10T13:25:32Z by daira
- Description modified (diff)
- Summary changed from 'make clean' shouldn't remove the src/allmydata_tahoe.egg-info directory to the src/allmydata_tahoe.egg-info directory shouldn't be included in sdist tarballs
https://github.com/tahoe-lafs/tahoe-lafs/pull/63