Make the PyPI distribution name consistent with the domain name and debian packages.

[nejucomo]

Criteria:

This ticket is closed when the PyPI package name is tahoe-lafs, otherwise this ticket is set to a different unopen status.

Synopsis:

The distribution names are inconsistent, as seen in: ​https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1950#comment:6

• PyPI package name is allmydata-tahoe
• The debian name is tahoe-lafs
• The domain name is tahoe-lafs.org: ​https://tahoe-lafs.org
• The github name is tahoe-lafs: ​https://github.com/tahoe-lafs/
• Anecdotally the common "spoken name" is either "tahoe" or "tahoe lafs".

I propose we alter the PyPI package to match the others: tahoe-lafs

Related:

• #1950 is about a larger, more time consuming project which involves changing the python module names as well.

[daira]

This was blocked on #1159 which is now fixed.

If we changed the package name for 1.11, that would mean nodes created by 1.11 could not be run by versions earlier than 1.10.1, but that's probably fine.

[daira]

This ticket also implies changing the name we use for git tags, currently patterned as allmydata-tahoe-1.11, to e.g. tahoe-lafs-1.12. (setup.py​ already makes this naming assumption as of e1a3a2001f37ce4225fb0f600c7eb30d9a061e06/trunk.)

[daira]

As part of fixing this we should check there are no more references to "allmydata-tahoe" in code or comments.

[daira]

​https://github.com/tahoe-lafs/tahoe-lafs/commits/2011-allmydataectomy-1 (the last two commits).

This is not a pull request yet because it is scheduled for after v1.10.1.

[daira]

Also note that builds of the above branch will fail unless there is a tag in the history with name starting "tahoe-lafs-" (e.g. see ​https://travis-ci.org/tahoe-lafs/tahoe-lafs/jobs/43273843#L436). This is intentional.

[warner]

Milestone renamed

[warner]

I want this in 1.11, so that we can recommend pip install tahoe-lafs right off the bat, rather than having an intermediate period where the instructions say pip install allmydata-tahoe.

[warner]

When this lands, we should add a ​Obsoletes-Dist field to our setup.py metadata, to point at the old allmydata-tahoe name.

[warner]

Replying to daira:

If we changed the package name for 1.11, that would mean nodes created by 1.11 could not be run by versions earlier than 1.10.1, but that's probably fine.

I need to test it, but we stopped using the contents of the .tac files back in 1.9.2 (commit [87a6894e62] on 23-May-2012). So I think the lingering pkg_resources.require('allmydata-tahoe') in them won't affect our backwards-compatibility story very much.

[warner]

Oops, I'm wrong, 1.10.0 *does* use the contents of the tac file (it runs twistd -y $TAC), but 1.10.1 does not. Same argument applies: building a node with the new name=tahoe-lafs 1.11.0 release, then rolling back to 1.10.0 (released in may of 2013), would break.

[warner]

Daira had a great idea: we could help old tahoe versions produce a better error message by writing out .tac files that throw an error if they're imported.

Newer Tahoes don't use the contents of the .tac file at all: they just look at the file name to decide what type of node it is, then instantiate the appropriate class (client, introducer, stats-gatherer, etc). Older Tahoes use twistd -y tac, which imports the .tac file.

So we can raise RuntimeError in the new .tac files, and then older tahoes will print the exception when they attempt to run twistd on it.

[Daira Hopwood <daira@…>]

In 0598c83/trunk:

Rename distribution from allmydata-tahoe to tahoe-lafs. fixes ticket:2011

Signed-off-by: Daira Hopwood <daira@…>