Opened at 2012-11-08T01:49:22Z

Last modified at 2014-04-22T14:47:23Z

#1847 closed defect

Ugly shadowing of Client.DEFAULT_ENCODING_PARAMETERS — at Version 4

Reported by: davidsarah Owned by: davidsarah
Priority: minor Milestone: 1.10.1
Component: code-encoding Version: 1.9.2
Keywords: reviewed Cc:
Launchpad Bug:

Description (last modified by daira)

Client in git/src/allmydata/client.py has a class attribute called DEFAULT_ENCODING_PARAMETERS, and an instance attribute also called DEFAULT_ENCODING_PARAMETERS that shadows it. This is ugly and confusing.

The linked pull request changes the name of the latter to _encoding_parameters.

Change History (4)

comment:1 Changed at 2012-11-08T02:11:38Z by davidsarah

  • Keywords review-needed added
  • Owner changed from davidsarah to warner

​https://github.com/tahoe-lafs/tahoe-lafs/pull/18

comment:2 Changed at 2012-11-08T16:19:01Z by davidsarah

  • Keywords review-needed removed
  • Owner changed from warner to davidsarah
  • Status changed from new to assigned

Hmm, given the amount of test code that sets encoding parameters, it may be worth adding a set_encoding_parameters method to Client. So please hold off merging this.

Last edited at 2012-11-08T16:19:24Z by davidsarah (previous) (diff)

comment:3 follow-up: Changed at 2013-04-10T06:36:22Z by zooko

Could this be related to #1830?

comment:4 in reply to: ↑ 3 Changed at 2013-06-20T11:40:04Z by daira

  • Description modified (diff)

Replying to zooko:

Could this be related to #1830?

No, see 1830#comment:5.

Note: See TracTickets for help on using tickets.