Changes between Initial Version and Version 1 of Ticket #1847, comment 26


Ignore:
Timestamp:
2014-04-14T22:11:28Z (11 years ago)
Author:
daira
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1847, comment 26

    initial v1  
    22> Also, wiki:CodingStandards says "Prepend a leading underscore to private names.", so the way https://github.com/daira/tahoe-lafs/commit/ab9216e5728083a671060ba12c98f56638f08517 did that is preferred.
    33
    4 I disagree, because these attributes aren't private. (I count attributes as non-private if they are accessed directly from anywhere outsiede the class, including tests.) The patch looks fine to me in this respect; I had originally planned to add a method to set parameters, but I think it's not needed.
     4I disagree, because these attributes aren't private. (I count attributes as non-private if they are accessed directly from anywhere outside the class, including tests.) The patch looks fine to me in this respect; I had originally planned to add a method to set parameters, but I think it's not needed.