Changes between Version 1 and Version 2 of Ticket #1836, comment 22
- Timestamp:
- 2014-05-05T16:51:56Z (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #1836, comment 22
v1 v2 3 3 Good job with this change. There are a few small things that I found. 4 4 5 I could not run the full test suite. It might be because this branch was made on a somewhat old version of tahoe-lafs. There are a bunch of " exceptions.ImportError: cannot import name HTTPConnectionPool" in the tests. If you could merge your branch with the latest trunk version, it might solve this.5 I could not run the full test suite. It might be because this branch was made on a somewhat old version of tahoe-lafs. There are a bunch of "`exceptions.ImportError: cannot import name !HTTPConnectionPool`" in the tests. If you could merge your branch with the latest trunk version, it might solve this. 6 6 7 In src/allmydata/web/storage.py, it seems like there are still a few remaining BucketCountingCrawler stuff left. For instance, in StorageStatus.render_JSON, you are still returning bucket-counter even though it returns None for it. Is this because the UI expects it? If this is the case, the UI might need to be changed as well as the backend. Another one is StorageStatus.render_count_crawler_status. Is this still needed for something if the crawler was removed?7 In `src/allmydata/web/storage.py`, it seems like there are still a few remaining `BucketCountingCrawler` stuff left. For instance, in `StorageStatus.render_JSON`, you are still returning bucket-counter even though it returns None for it. Is this because the UI expects it? If this is the case, the UI might need to be changed as well as the backend. Another one is `StorageStatus.render_count_crawler_status`. Is this still needed for something if the crawler was removed? 8 8 9 9 Reassigning to markberger to fix those issues.
