Changes between Initial Version and Version 1 of Ticket #1836, comment 22


Ignore:
Timestamp:
2014-05-05T15:41:26Z (11 years ago)
Author:
remyroy
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1836, comment 22

    initial v1  
    55I could not run the full test suite. It might be because this branch was made on a somewhat old version of tahoe-lafs. There are a bunch of "exceptions.ImportError: cannot import name HTTPConnectionPool" in the tests. If you could merge your branch with the latest trunk version, it might solve this.
    66
    7 In src/allmydata/web/storage.py, it seems like there are still a few remaining BucketCountingCrawler stuff there are still left. For instance, in StorageStatus.render_JSON, you are still returning bucket-counter even though it returns None for it. Is this because the UI expects it? If this is the case, the UI might need to be changed as well as the backend. Another one is StorageStatus.render_count_crawler_status . Is this still needed for something if the crawler was removed?
     7In src/allmydata/web/storage.py, it seems like there are still a few remaining BucketCountingCrawler stuff left. For instance, in StorageStatus.render_JSON, you are still returning bucket-counter even though it returns None for it. Is this because the UI expects it? If this is the case, the UI might need to be changed as well as the backend. Another one is StorageStatus.render_count_crawler_status . Is this still needed for something if the crawler was removed?
    88
    99Reassigning to markberger to fix those issues.