Opened at 2011-01-14T04:56:34Z

Closed at 2011-01-31T07:18:16Z

Last modified at 2011-01-31T12:55:34Z

#1306 closed defect (fixed)

release 1.8.2

Reported by: davidsarah Owned by: warner
Priority: major Milestone: 1.8.2
Component: packaging Version: 1.8.1
Keywords: release Cc:
Launchpad Bug:

Description


Attachments (2)

docs-for-1.8.2.darcs.patch​ (6.3 KB) - added by zooko at 2011-01-28T15:47:13Z.
docs.diff​ (5.7 KB) - added by warner at 2011-01-31T02:14:51Z.
last-minute docs changes for double-checking

Download all attachments as: .zip

Change History (12)

comment:1 Changed at 2011-01-15T07:32:38Z by zooko

+1 on 33786a6d55661cea! Please push it into trunk! :-) (And watch what happens to all the Supported Builders before and after.)

comment:2 Changed at 2011-01-17T09:32:52Z by warner

  • Owner changed from somebody to warner
  • Status changed from new to assigned

comment:3 Changed at 2011-01-21T08:06:22Z by david-sarah@…

In f3b4f4181cba3dde:

src/allmydata/_auto_deps.py: 'pysqlite.dbapi2' module should have been 'pysqlite2.dbapi2'. refs #1306

comment:4 Changed at 2011-01-22T04:58:08Z by david-sarah@…

In cb02adb11027165e:

Don't put debugging information in 'My versions' section of the Welcome page. Also remove the extra blank line between version and command output when --version[-and-path] is used. refs #1306

comment:5 follow-up: Changed at 2011-01-22T07:13:33Z by zooko

Reviewed: c8ccb297fa7f499d, 0c51ce3d8935d170, 74aba7dd264083e0, f84f2aa98777c10d, 8f4ae53f391429ed, ae3373188cc223c9, a008c79762b695d7, 6d6f0edc3698e1ab, 3c161c9a96dd09fe, 3eadc8a05375656f (yay! I love this patch!), cb02adb11027165e.

Question about 39eede4217997b22: why is quotemarks=False used in the first call to quote_output() and not in the others?

comment:6 in reply to: ↑ 5 Changed at 2011-01-22T07:43:00Z by davidsarah

Replying to zooko:

Question about 39eede4217997b22: why is quotemarks=False used in the first call to quote_output() and not in the others?

Just because there weren't any quotes in the existing "No such child: %s".

comment:7 follow-up: Changed at 2011-01-28T15:40:05Z by zooko

I will attach some documentation patches.

Changed at 2011-01-28T15:47:13Z by zooko

comment:8 in reply to: ↑ 7 Changed at 2011-01-30T05:06:20Z by davidsarah

Replying to zooko:

I will attach some documentation patches.

Why is the allmydata.com -> tahoe-lafs.org patch doing the reverse change in some places, only to then change it back?

I'm not sure I trust replace patches at all. Just by looking at the patch, I can't see whether they're correct, or whether they're changing stuff that should be left as-is. In particular I don't really see the need to change references to allmydata.org for earlier entries in NEWS, for example. Those entries should be immutable -- or perhaps we should add a note "Links to allmydata.org below should now be tahoe-lafs.org."

Version 0, edited at 2011-01-30T05:06:20Z by davidsarah (next)

Changed at 2011-01-31T02:14:51Z by warner

last-minute docs changes for double-checking

comment:9 Changed at 2011-01-31T07:18:16Z by warner

  • Resolution set to fixed
  • Status changed from assigned to closed

release is tagged 36d1cce5f0569fea and announcements will be sent out shortly. Hurray!

Note: See TracTickets for help on using tickets.