#1282 closed defect (fixed)
remove unmaintained Mac and Windows apps
| Reported by: | davidsarah | Owned by: | warner |
|---|---|---|---|
| Priority: | major | Milestone: | 1.8.2 |
| Component: | code | Version: | 1.8.1 |
| Keywords: | mac windows news-needed reviewed | Cc: | |
| Launchpad Bug: |
Description (last modified by davidsarah)
The Mac OS X GUI application in mac, and the Windows GUI application in windows, are unmaintained, untested, and depend on the allmydata.com user account system which is no longer in operation. They should be either removed from the tree, or fixed to not depend on the allmydata.com account system.
(I think these apps are not helpful for allowing allmydata.com customers using Mac OS X or Windows to retrieve their data; please correct me if I'm wrong on that point.)
Both of these apps depend on src/allmydata/gui/confwiz.py.
(Note when reading up to comment:4 -- this ticket was originally about only the Mac app.)
Attachments (3)
Change History (21)
comment:1 follow-up: ↓ 2 Changed at 2010-12-26T00:51:53Z by warner
comment:2 in reply to: ↑ 1 Changed at 2010-12-26T02:22:29Z by davidsarah
Replying to warner:
good point. maybe we should move it to contrib/ to serve as reference material? It'd be nice if the code were usable to somebody in the future, to build a new GUI.
-1 on moving it to contrib/, since anyone building a new GUI can just check out a revision before the removal (e.g. the allmydata-tahoe-1.8.1 tag).
Note that changeset 00aa75d1e8b8b188 moved some of the FUSE-related code from the Mac app to become contrib/fuse/impl_c/blackmatch.py. For future historians, here are some notes that might be useful:
- when invoked with command-line options, the Mac app would run the tahoe CLI, but with an extra tahoe fuse subcommand. This was implemented at mac/allmydata_tahoe.py@2186#L25. The tahoefuse module imported there is actually blackmatch.py (copied by the build process).
- the options passed to tahoe fuse by the GUI app when mounting a filesystem are given at src/allmydata/gui/macapp.py@4329#L482.
comment:3 Changed at 2010-12-26T02:43:32Z by davidsarah
- Keywords review-needed added
- Owner changed from somebody to warner
Changed at 2010-12-26T03:30:49Z by davidsarah
Remove unmaintained Mac GUI app. This version also removes the Makefile targets.
comment:4 Changed at 2010-12-26T03:43:46Z by davidsarah
- Description modified (diff)
- Keywords windows added
- Owner changed from warner to davidsarah
- Status changed from new to assigned
- Summary changed from remove unmaintained Mac app to remove unmaintained Mac and Windows apps
comment:5 Changed at 2010-12-26T03:52:00Z by davidsarah
- Milestone changed from 1.9.0 to undecided
I hadn't realized that the code in src/allmydata/gui was portable between Mac and Windows (and other platforms supporting wxWindows). It does still depend on the allmydata.com account system, but maybe we should be trying to remove that dependency rather than removing these apps.
comment:6 Changed at 2010-12-26T03:58:14Z by davidsarah
In particular, windows/tahoe.py windows/tahoesvc.py includes code to run a storage server as a Windows service. That seems worth saving (and perhaps including as an option to tahoe run, or the default behaviour of tahoe start on Windows).
comment:7 Changed at 2010-12-26T04:04:45Z by davidsarah
- Description modified (diff)
- Keywords review-needed removed
- Summary changed from remove unmaintained Mac and Windows apps to remove or fix unmaintained Mac and Windows apps
comment:8 Changed at 2010-12-26T04:53:27Z by davidsarah
After looking more closely at src/allmydata/gui/confwiz.py, it is almost entirely concerned with allmydata.com stuff that is no longer useful.
This code does encode some lore about how to create stub Mac and Windows GUI apps. I'm not sure this is worth keeping in the tree without any useful GUI code to run.
I'll move windows/tahoesvc.py into src/allmydata/windows in order to retain its revision history. It will need more work to be usable, because it currently depends on the tahoe process being an executable created by py2exe (http://agiletesting.blogspot.com/2005/09/running-python-script-as-windows.html says that it is possible to run a batch file as a service, though).
Changed at 2010-12-26T04:54:48Z by davidsarah
Remove unmaintained Mac and Windows GUI apps. Supercedes previous patches.
comment:9 Changed at 2010-12-26T04:59:35Z by davidsarah
- Keywords review-needed added
- Milestone changed from undecided to 1.9.0
- Owner changed from davidsarah to warner
- Status changed from assigned to new
comment:10 Changed at 2010-12-26T05:44:27Z by davidsarah
- Description modified (diff)
- Summary changed from remove or fix unmaintained Mac and Windows apps to remove unmaintained Mac and Windows apps
comment:11 Changed at 2011-01-02T04:41:30Z by Zarutian
- Keywords reviewed added; review-needed removed
I say we remove those two apps as their code would continue to exists in the source tree as a earlier revisions. Anyone who wants to write comperable GUI app can go spelunking. Perhaps a pointer to the last revision containing them can be added in the documentation to help potential future GUI app writers.
comment:12 Changed at 2011-01-02T05:24:57Z by david-sarah@…
- Resolution set to fixed
- Status changed from new to closed
In 195ddbcf7cde56d0:
comment:13 Changed at 2011-01-02T05:24:57Z by david-sarah@…
In 89c71a8c2c72e87b:
comment:14 Changed at 2011-01-02T05:24:58Z by david-sarah@…
In 2182c9084ed93b8e:
comment:15 Changed at 2011-01-02T05:24:58Z by david-sarah@…
In 3132c9b593a6664b:
comment:16 Changed at 2011-01-02T05:24:58Z by david-sarah@…
In 2c099ffa0d7412ab:
comment:17 Changed at 2011-01-02T05:24:59Z by david-sarah@…
In e3974d125aacbb6f:
comment:18 Changed at 2011-01-06T00:41:25Z by davidsarah
- Milestone changed from 1.9.0 to 1.8.2
good point. maybe we should move it to contrib/ to serve as reference material? It'd be nice if the code were usable to somebody in the future, to build a new GUI.