Opened at 2010-11-04T01:36:41Z
Last modified at 2019-07-25T12:59:26Z
#1248 closed defect
refactor buildmaster Test classes and build_helper scripts — at Initial Version
| Reported by: | davidsarah | Owned by: | somebody |
|---|---|---|---|
| Priority: | normal | Milestone: | soon |
| Component: | dev-infrastructure | Version: | 1.8.0 |
| Keywords: | buildbot build-helpers cleanup install setuptools pycryptopp zfec | Cc: | |
| Launchpad Bug: |
Description
There is some near-duplicated code in the buildmaster's TestFromEgg and TestFromPrefixDir classes (in bbsupport.py). There is also duplication between setup.py, misc/build_helpers/run_trial.py, and some of the tests in src/allmydata/test/test_runner.py, for things like setting up PYTHONPATH, getting the Tahoe-LAFS version, and checking that we are running code from the right directory.
Code in the buildmaster is more difficult to debug than code in the Tahoe-LAFS distribution; changes require a buildmaster restart to take effect, and interfere with the reproducibility of builds. So we should simplify these classes by having them just call scripts (or a single script with different arguments) in misc/build_helpers.
The reason why the code that is already in the distribution isn't better-factored, is probably that in each case we need to run it before importing any non-stdlib modules. It seems like there should be some way to work around that.
