Changes between Initial Version and Version 12 of Ticket #1240


Ignore:
Timestamp:
2012-05-05T14:38:43Z (12 years ago)
Author:
lebek
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1240

    • Property Summary changed from add functional test of ResponseCache to remove ResponseCache in favour of MDMFSlotReadProxy's cache
    • Property Keywords review-needed added; test-needed removed
    • Property Milestone changed from soon to 1.10.0
    • Property Owner set to lebek
  • Ticket #1240 – Description

    initial v12  
    1 There are unit tests of the mutable {{{ResponseCache}}} (at [source:src/allmydata/test/test_mutable.py@4772#L1719], but no functional tests of how it is used. (As noted in [ticket:1045#comment:39], deactivating the cache by commenting out the line that adds entries to it will currently cause all tests to pass.)
     1{{{MDMFSlotReadProxy}}} can already be initialised with share data which it uses in preference to fetching from the server. By exploiting this behaviour we can remove {{{ResponseCache}}} which does essentially the same thing.
     2
     3{{{ResponseCache}}} had no functional tests of how it is used (as noted in [ticket:1045#comment:39], deactivating the cache by commenting out the line that adds entries to it will currently cause all tests to pass). The {{{MDMFSlotReadProxy}}}  cache will require a test of this type.
    24
    35One way to test that the cache is working would be to download a file, then break all of the servers holding its shares, then download it again in order to check that the shares are retrieved from cache rather than from the servers.