1 | | There are unit tests of the mutable {{{ResponseCache}}} (at [source:src/allmydata/test/test_mutable.py@4772#L1719], but no functional tests of how it is used. (As noted in [ticket:1045#comment:39], deactivating the cache by commenting out the line that adds entries to it will currently cause all tests to pass.) |
| 1 | {{{MDMFSlotReadProxy}}} can already be initialised with share data which it uses in preference to fetching from the server. By exploiting this behaviour we can remove {{{ResponseCache}}} which does essentially the same thing. |
| 2 | |
| 3 | {{{ResponseCache}}} had no functional tests of how it is used (as noted in [ticket:1045#comment:39], deactivating the cache by commenting out the line that adds entries to it will currently cause all tests to pass). The {{{MDMFSlotReadProxy}}} cache will require a test of this type. |