Ticket #393: 393-fix-interfaces.darcs.patch

File 393-fix-interfaces.darcs.patch, 65.3 KB (added by davidsarah, at 2011-08-25T02:49:08Z)

Fix interfaces related to MDMF. refs #393 Also some grammar corrections, and removal of 'self' from interface method declarations in interfaces.py

Line 
12 patches for repository davidsarah@dev.allmydata.org:/home/darcs/tahoe/trunk:
2
3Thu Aug 25 01:32:17 BST 2011  david-sarah@jacaranda.org
4  * interfaces.py: 'which -> that' grammar cleanup.
5
6Thu Aug 25 02:30:46 BST 2011  david-sarah@jacaranda.org
7  * Fix interfaces related to MDMF. refs #393
8
9New patches:
10
11[interfaces.py: 'which -> that' grammar cleanup.
12david-sarah@jacaranda.org**20110825003217
13 Ignore-this: a3e15f3676de1b346ad78aabdfb8cac6
14] {
15hunk ./src/allmydata/interfaces.py 38
16     the StubClient. This object doesn't actually offer any services, but the
17     announcement helps the Introducer keep track of which clients are
18     subscribed (so the grid admin can keep track of things like the size of
19-    the grid and the client versions in use. This is the (empty)
20+    the grid and the client versions in use). This is the (empty)
21     RemoteInterface for the StubClient."""
22 
23 class RIBucketWriter(RemoteInterface):
24hunk ./src/allmydata/interfaces.py 268
25         (binary) storage index string, and 'shnum' is the integer share
26         number. 'reason' is a human-readable explanation of the problem,
27         probably including some expected hash values and the computed ones
28-        which did not match. Corruption advisories for mutable shares should
29+        that did not match. Corruption advisories for mutable shares should
30         include a hash of the public key (the same value that appears in the
31         mutable-file verify-cap), since the current share format does not
32         store that on disk.
33hunk ./src/allmydata/interfaces.py 405
34           remote_host: the IAddress, if connected, otherwise None
35 
36         This method is intended for monitoring interfaces, such as a web page
37-        which describes connecting and connected peers.
38+        that describes connecting and connected peers.
39         """
40 
41     def get_all_peerids():
42hunk ./src/allmydata/interfaces.py 507
43 
44     # TODO: rename to get_read_cap()
45     def get_readonly():
46-        """Return another IURI instance, which represents a read-only form of
47+        """Return another IURI instance that represents a read-only form of
48         this one. If is_readonly() is True, this returns self."""
49 
50     def get_verify_cap():
51hunk ./src/allmydata/interfaces.py 534
52         passing into init_from_string."""
53 
54 class IDirnodeURI(Interface):
55-    """I am a URI which represents a dirnode."""
56+    """I am a URI that represents a dirnode."""
57 
58 class IFileURI(Interface):
59hunk ./src/allmydata/interfaces.py 537
60-    """I am a URI which represents a filenode."""
61+    """I am a URI that represents a filenode."""
62     def get_size():
63         """Return the length (in bytes) of the file that I represent."""
64 
65hunk ./src/allmydata/interfaces.py 545
66     pass
67 
68 class IMutableFileURI(Interface):
69-    """I am a URI which represents a mutable filenode."""
70+    """I am a URI that represents a mutable filenode."""
71     def get_extension_params():
72         """Return the extension parameters in the URI"""
73 
74hunk ./src/allmydata/interfaces.py 848
75         """
76 
77 class IFileNode(IFilesystemNode):
78-    """I am a node which represents a file: a sequence of bytes. I am not a
79+    """I am a node that represents a file: a sequence of bytes. I am not a
80     container, like IDirectoryNode."""
81     def get_best_readable_version():
82         """Return a Deferred that fires with an IReadable for the 'best'
83hunk ./src/allmydata/interfaces.py 897
84     multiple versions of a file present in the grid, some of which might be
85     unrecoverable (i.e. have fewer than 'k' shares). These versions are
86     loosely ordered: each has a sequence number and a hash, and any version
87-    with seqnum=N was uploaded by a node which has seen at least one version
88+    with seqnum=N was uploaded by a node that has seen at least one version
89     with seqnum=N-1.
90 
91     The 'servermap' (an instance of IMutableFileServerMap) is used to
92hunk ./src/allmydata/interfaces.py 1006
93         as a guide to where the shares are located.
94 
95         I return a Deferred that fires with the requested contents, or
96-        errbacks with UnrecoverableFileError. Note that a servermap which was
97+        errbacks with UnrecoverableFileError. Note that a servermap that was
98         updated with MODE_ANYTHING or MODE_READ may not know about shares for
99         all versions (those modes stop querying servers as soon as they can
100         fulfil their goals), so you may want to use MODE_CHECK (which checks
101hunk ./src/allmydata/interfaces.py 1062
102     """Upload was unable to satisfy 'servers_of_happiness'"""
103 
104 class UnableToFetchCriticalDownloadDataError(Exception):
105-    """I was unable to fetch some piece of critical data which is supposed to
106+    """I was unable to fetch some piece of critical data that is supposed to
107     be identically present in all shares."""
108 
109 class NoServersError(Exception):
110hunk ./src/allmydata/interfaces.py 1074
111     exists, and overwrite= was set to False."""
112 
113 class NoSuchChildError(Exception):
114-    """A directory node was asked to fetch a child which does not exist."""
115+    """A directory node was asked to fetch a child that does not exist."""
116 
117 class ChildOfWrongTypeError(Exception):
118     """An operation was attempted on a child of the wrong type (file or directory)."""
119hunk ./src/allmydata/interfaces.py 1392
120         if you initially thought you were going to use 10 peers, started
121         encoding, and then two of the peers dropped out: you could use
122         desired_share_ids= to skip the work (both memory and CPU) of
123-        producing shares for the peers which are no longer available.
124+        producing shares for the peers that are no longer available.
125 
126         """
127 
128hunk ./src/allmydata/interfaces.py 1467
129         if you initially thought you were going to use 10 peers, started
130         encoding, and then two of the peers dropped out: you could use
131         desired_share_ids= to skip the work (both memory and CPU) of
132-        producing shares for the peers which are no longer available.
133+        producing shares for the peers that are no longer available.
134 
135         For each call, encode() will return a Deferred that fires with two
136         lists, one containing shares and the other containing the shareids.
137hunk ./src/allmydata/interfaces.py 1524
138         required to be of the same length.  The i'th element of their_shareids
139         is required to be the shareid of the i'th buffer in some_shares.
140 
141-        This returns a Deferred which fires with a sequence of buffers. This
142+        This returns a Deferred that fires with a sequence of buffers. This
143         sequence will contain all of the segments of the original data, in
144         order. The sum of the lengths of all of the buffers will be the
145         'data_size' value passed into the original ICodecEncode.set_params()
146hunk ./src/allmydata/interfaces.py 1571
147         Encoding parameters can be set in three ways. 1: The Encoder class
148         provides defaults (3/7/10). 2: the Encoder can be constructed with
149         an 'options' dictionary, in which the
150-        needed_and_happy_and_total_shares' key can be a (k,d,n) tuple. 3:
151+        'needed_and_happy_and_total_shares' key can be a (k,d,n) tuple. 3:
152         set_params((k,d,n)) can be called.
153 
154         If you intend to use set_params(), you must call it before
155hunk ./src/allmydata/interfaces.py 1769
156         produced, so that the segment hashes can be generated with only a
157         single pass.
158 
159-        This returns a Deferred which fires with a sequence of hashes, using:
160+        This returns a Deferred that fires with a sequence of hashes, using:
161 
162          tuple(segment_hashes[first:last])
163 
164hunk ./src/allmydata/interfaces.py 1785
165     def get_plaintext_hash():
166         """OBSOLETE; Get the hash of the whole plaintext.
167 
168-        This returns a Deferred which fires with a tagged SHA-256 hash of the
169+        This returns a Deferred that fires with a tagged SHA-256 hash of the
170         whole plaintext, obtained from hashutil.plaintext_hash(data).
171         """
172 
173hunk ./src/allmydata/interfaces.py 1845
174         be used to encrypt the data. The key will also be hashed to derive
175         the StorageIndex.
176 
177-        Uploadables which want to achieve convergence should hash their file
178+        Uploadables that want to achieve convergence should hash their file
179         contents and the serialized_encoding_parameters to form the key
180         (which of course requires a full pass over the data). Uploadables can
181         use the upload.ConvergentUploadMixin class to achieve this
182hunk ./src/allmydata/interfaces.py 1851
183         automatically.
184 
185-        Uploadables which do not care about convergence (or do not wish to
186+        Uploadables that do not care about convergence (or do not wish to
187         make multiple passes over the data) can simply return a
188         strongly-random 16 byte string.
189 
190hunk ./src/allmydata/interfaces.py 1861
191 
192     def read(length):
193         """Return a Deferred that fires with a list of strings (perhaps with
194-        only a single element) which, when concatenated together, contain the
195+        only a single element) that, when concatenated together, contain the
196         next 'length' bytes of data. If EOF is near, this may provide fewer
197         than 'length' bytes. The total number of bytes provided by read()
198         before it signals EOF must equal the size provided by get_size().
199hunk ./src/allmydata/interfaces.py 1908
200 
201     def read(length):
202         """
203-        Returns a list of strings which, when concatenated, are the next
204+        Returns a list of strings that, when concatenated, are the next
205         length bytes of the file, or fewer if there are fewer bytes
206         between the current location and the end of the file.
207         """
208hunk ./src/allmydata/interfaces.py 1921
209 
210 class IUploadResults(Interface):
211     """I am returned by upload() methods. I contain a number of public
212-    attributes which can be read to determine the results of the upload. Some
213+    attributes that can be read to determine the results of the upload. Some
214     of these are functional, some are timing information. All of these may be
215     None.
216 
217hunk ./src/allmydata/interfaces.py 1954
218 
219 class IDownloadResults(Interface):
220     """I am created internally by download() methods. I contain a number of
221-    public attributes which contain details about the download process.::
222+    public attributes that contain details about the download process.::
223 
224      .file_size : the size of the file, in bytes
225      .servers_used : set of server peerids that were used during download
226hunk ./src/allmydata/interfaces.py 1980
227 class IUploader(Interface):
228     def upload(uploadable):
229         """Upload the file. 'uploadable' must impement IUploadable. This
230-        returns a Deferred which fires with an IUploadResults instance, from
231+        returns a Deferred that fires with an IUploadResults instance, from
232         which the URI of the file can be obtained as results.uri ."""
233 
234     def upload_ssk(write_capability, new_version, uploadable):
235hunk ./src/allmydata/interfaces.py 2030
236         kind of lease that is obtained (which account number to claim, etc).
237 
238         TODO: any problems seen during checking will be reported to the
239-        health-manager.furl, a centralized object which is responsible for
240+        health-manager.furl, a centralized object that is responsible for
241         figuring out why files are unhealthy so corrective action can be
242         taken.
243         """
244hunk ./src/allmydata/interfaces.py 2045
245         will be put in the check-and-repair results. The Deferred will not
246         fire until the repair is complete.
247 
248-        This returns a Deferred which fires with an instance of
249+        This returns a Deferred that fires with an instance of
250         ICheckAndRepairResults."""
251 
252 class IDeepCheckable(Interface):
253hunk ./src/allmydata/interfaces.py 2130
254                               that was found to be corrupt. Each share
255                               locator is a list of (serverid, storage_index,
256                               sharenum).
257-         count-incompatible-shares: the number of shares which are of a share
258+         count-incompatible-shares: the number of shares that are of a share
259                                     format unknown to this checker
260          list-incompatible-shares: a list of 'share locators', one for each
261                                    share that was found to be of an unknown
262hunk ./src/allmydata/interfaces.py 2137
263                                    format. Each share locator is a list of
264                                    (serverid, storage_index, sharenum).
265          servers-responding: list of (binary) storage server identifiers,
266-                             one for each server which responded to the share
267+                             one for each server that responded to the share
268                              query (even if they said they didn't have
269                              shares, and even if they said they did have
270                              shares but then didn't send them when asked, or
271hunk ./src/allmydata/interfaces.py 2334
272         will use the data in the checker results to guide the repair process,
273         such as which servers provided bad data and should therefore be
274         avoided. The ICheckResults object is inside the
275-        ICheckAndRepairResults object, which is returned by the
276+        ICheckAndRepairResults object that is returned by the
277         ICheckable.check() method::
278 
279          d = filenode.check(repair=False)
280hunk ./src/allmydata/interfaces.py 2425
281         methods to create new objects. I return synchronously."""
282 
283     def create_mutable_file(contents=None, keysize=None):
284-        """I create a new mutable file, and return a Deferred which will fire
285+        """I create a new mutable file, and return a Deferred that will fire
286         with the IMutableFileNode instance when it is ready. If contents= is
287         provided (a bytestring), it will be used as the initial contents of
288         the new file, otherwise the file will contain zero bytes. keysize= is
289hunk ./src/allmydata/interfaces.py 2433
290         usual."""
291 
292     def create_new_mutable_directory(initial_children={}):
293-        """I create a new mutable directory, and return a Deferred which will
294+        """I create a new mutable directory, and return a Deferred that will
295         fire with the IDirectoryNode instance when it is ready. If
296         initial_children= is provided (a dict mapping unicode child name to
297         (childnode, metadata_dict) tuples), the directory will be populated
298hunk ./src/allmydata/interfaces.py 2441
299 
300 class IClientStatus(Interface):
301     def list_all_uploads():
302-        """Return a list of uploader objects, one for each upload which
303+        """Return a list of uploader objects, one for each upload that
304         currently has an object available (tracked with weakrefs). This is
305         intended for debugging purposes."""
306     def list_active_uploads():
307hunk ./src/allmydata/interfaces.py 2451
308         started uploads."""
309 
310     def list_all_downloads():
311-        """Return a list of downloader objects, one for each download which
312+        """Return a list of downloader objects, one for each download that
313         currently has an object available (tracked with weakrefs). This is
314         intended for debugging purposes."""
315     def list_active_downloads():
316hunk ./src/allmydata/interfaces.py 2678
317 
318     def provide(provider=RIStatsProvider, nickname=str):
319         """
320-        @param provider: a stats collector instance which should be polled
321+        @param provider: a stats collector instance that should be polled
322                          periodically by the gatherer to collect stats.
323         @param nickname: a name useful to identify the provided client
324         """
325hunk ./src/allmydata/interfaces.py 2711
326 
327 class IValidatedThingProxy(Interface):
328     def start():
329-        """ Acquire a thing and validate it. Return a deferred which is
330+        """ Acquire a thing and validate it. Return a deferred that is
331         eventually fired with self if the thing is valid or errbacked if it
332         can't be acquired or validated."""
333 
334}
335[Fix interfaces related to MDMF. refs #393
336david-sarah@jacaranda.org**20110825013046
337 Ignore-this: ee510c7261f8b328f0db218d71208ca3
338] {
339hunk ./src/allmydata/interfaces.py 428
340     """
341     The interface for a writer around a mutable slot on a remote server.
342     """
343-    def set_checkstring(checkstring, *args):
344+    def set_checkstring(checkstring, checkstring_or_seqnum, root_hash=None, salt=None):
345         """
346         Set the checkstring that I will pass to the remote server when
347         writing.
348hunk ./src/allmydata/interfaces.py 457
349         Add the encrypted private key to the share.
350         """
351 
352-    def put_blockhashes(blockhashes=list):
353+    def put_blockhashes(blockhashes):
354         """
355hunk ./src/allmydata/interfaces.py 459
356+        @param blockhashes=list
357         Add the block hash tree to the share.
358         """
359 
360hunk ./src/allmydata/interfaces.py 463
361-    def put_sharehashes(sharehashes=dict):
362+    def put_sharehashes(sharehashes):
363         """
364hunk ./src/allmydata/interfaces.py 465
365+        @param sharehashes=dict
366         Add the share hash chain to the share.
367         """
368 
369hunk ./src/allmydata/interfaces.py 551
370     def get_extension_params():
371         """Return the extension parameters in the URI"""
372 
373-    def set_extension_params():
374+    def set_extension_params(params):
375         """Set the extension parameters that should be in the URI"""
376 
377 class IDirectoryURI(Interface):
378hunk ./src/allmydata/interfaces.py 1985
379         returns a Deferred that fires with an IUploadResults instance, from
380         which the URI of the file can be obtained as results.uri ."""
381 
382-    def upload_ssk(write_capability, new_version, uploadable):
383-        """TODO: how should this work?"""
384-
385 class ICheckable(Interface):
386     def check(monitor, verify=False, add_lease=False):
387         """Check up on my health, optionally repairing any problems.
388hunk ./src/allmydata/interfaces.py 2346
389 
390 class IRepairResults(Interface):
391     """I contain the results of a repair operation."""
392-    def get_successful(self):
393+    def get_successful():
394         """Returns a boolean: True if the repair made the file healthy, False
395         if not. Repair failure generally indicates a file that has been
396         damaged beyond repair."""
397hunk ./src/allmydata/monitor.py 30
398 
399     # the following methods are provided for the operation code
400 
401-    def is_cancelled(self):
402+    def is_cancelled():
403         """Returns True if the operation has been cancelled. If True,
404         operation code should stop creating new work, and attempt to stop any
405         work already in progress."""
406hunk ./src/allmydata/monitor.py 35
407 
408-    def raise_if_cancelled(self):
409+    def raise_if_cancelled():
410         """Raise OperationCancelledError if the operation has been cancelled.
411         Operation code that has a robust error-handling path can simply call
412         this periodically."""
413hunk ./src/allmydata/monitor.py 40
414 
415-    def set_status(self, status):
416+    def set_status(status):
417         """Sets the Monitor's 'status' object to an arbitrary value.
418         Different operations will store different sorts of status information
419         here. Operation code should use get+modify+set sequences to update
420hunk ./src/allmydata/monitor.py 46
421         this."""
422 
423-    def get_status(self):
424+    def get_status():
425         """Return the status object. If the operation failed, this will be a
426         Failure instance."""
427 
428hunk ./src/allmydata/monitor.py 50
429-    def finish(self, status):
430+    def finish(status):
431         """Call this when the operation is done, successful or not. The
432         Monitor's lifetime is influenced by the completion of the operation
433         it is monitoring. The Monitor's 'status' value will be set with the
434hunk ./src/allmydata/monitor.py 63
435 
436     # the following methods are provided for the initiator of the operation
437 
438-    def is_finished(self):
439+    def is_finished():
440         """Return a boolean, True if the operation is done (whether
441         successful or failed), False if it is still running."""
442 
443hunk ./src/allmydata/monitor.py 67
444-    def when_done(self):
445+    def when_done():
446         """Return a Deferred that fires when the operation is complete. It
447         will fire with the operation status, the same value as returned by
448         get_status()."""
449hunk ./src/allmydata/monitor.py 72
450 
451-    def cancel(self):
452+    def cancel():
453         """Cancel the operation as soon as possible. is_cancelled() will
454         start returning True after this is called."""
455 
456hunk ./src/allmydata/uri.py 829
457     def is_mutable(self):
458         return False
459 
460+    def is_readonly(self):
461+        return True
462+
463+    def get_readonly(self):
464+        return self
465+
466+
467 class DirectoryURIVerifier(_DirectoryBaseURI):
468     implements(IVerifierURI)
469 
470hunk ./src/allmydata/uri.py 855
471     def is_mutable(self):
472         return False
473 
474+    def is_readonly(self):
475+        return True
476+
477+    def get_readonly(self):
478+        return self
479+
480 
481 class ImmutableDirectoryURIVerifier(DirectoryURIVerifier):
482     implements(IVerifierURI)
483}
484
485Context:
486
487[Implementation, tests and docs for blacklists. This version allows listing directories containing a blacklisted child. Inclusion of blacklist.py fixed. fixes #1425
488david-sarah@jacaranda.org**20110824155928
489 Ignore-this: a306f36bb6640eaf046e66dc4beeb11c
490]
491[mutable/layout.py: fix unused import. refs #393
492david-sarah@jacaranda.org**20110816225043
493 Ignore-this: 7c9d6d91521ceb9a7abd14b2c60c0604
494]
495[mutable/retrieve.py: cosmetics and remove a stale comment. refs #393
496david-sarah@jacaranda.org**20110816214612
497 Ignore-this: 916e60c9dff1ef85595822e609ff34b7
498]
499[mutable/filenode.py: don't fetch more segments than necesasry to update the file
500Kevan Carstensen <kevan@isnotajoke.com>**20110813210005
501 Ignore-this: 2b0ad0533baa6f19f18851317dfc9f15
502]
503[test/test_mutable: test for incorrect div_ceil equations
504Kevan Carstensen <kevan@isnotajoke.com>**20110813183936
505 Ignore-this: 74e6061ab2ec5e706a1235611f87d5d6
506]
507[mutable/retrieve.py: use floor division to calculate segment boundaries, don't fetch more segments than necessary
508Kevan Carstensen <kevan@isnotajoke.com>**20110813183833
509 Ignore-this: 3e272249107afd3fbc1dd30c6a4f1e31
510]
511[mdmf: clean up boolean expressions, correct typos, remove self._paused, and don't unconditionally initialize block hash trees, asll as suggested by davidsarahs' review comments
512Kevan Carstensen <kevan@isnotajoke.com>**20110813183710
513 Ignore-this: cc6ad9f98b64f379151aa58b77b6c4e5
514]
515[now that tests pass with full-size keys, return test-keys to normal (522bit)
516warner@lothar.com**20110811175418
517 Ignore-this: dbce8a6699ba9a90d91cffbc8aa87900
518]
519[fix SHARE_HASH_CHAIN_SIZE computation
520warner@lothar.com**20110811175350
521 Ignore-this: 4508359d2207c8c1b7552b546697264
522]
523[More idiomatic resolution of the conflict between ticket393-MDMF-2 and trunk. refs #393
524david-sarah@jacaranda.org**20110810202942
525 Ignore-this: 7fc54a30ab0bc6ce75b7d819800c1182
526]
527[Replace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE constant defined in test/common.py (part 2). refs #393
528david-sarah@jacaranda.org**20110810202310
529 Ignore-this: 7fbd4d004279599bbcb10f7b31fb010f
530]
531[Replace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE constant defined in test/common.py (part 1). refs #393
532david-sarah@jacaranda.org**20110810202243
533 Ignore-this: c58d8130a2f383ff4421c632499b027b
534]
535[merge some minor conflicts in test code from the 393-2 branch and trunk
536zooko@zooko.com**20110810172139
537 Ignore-this: 4a16f13eeae585c7c1dbe18c67072c90
538]
539[doc: eliminate the phrase "rootcap" from doc/frontends/FTP-and-SFTP.rst
540zooko@zooko.com**20110809132601
541 Ignore-this: f7e1dd212daa65c81fb57977bce24304
542 Two different people have asked me for help, saying they couldn't figure out what a "rootcap" is. Hopefully just calling it a "cap" will make it easier for them to find out from the other docs what it is.
543]
544[test_web.py: fix a test failure dependent on whether simplejson.loads returns a unicode or str object.
545david-sarah@jacaranda.org**20110808213925
546 Ignore-this: f7b267be8be56fcabc968e3c89999490
547]
548[immutable/filenode: fix pyflakes warnings
549Kevan Carstensen <kevan@isnotajoke.com>**20110807004514
550 Ignore-this: e8d875bf8b1c5571e31b0eff42ecf64c
551]
552[test: fix assorted tests broken by MDMF changes
553Kevan Carstensen <kevan@isnotajoke.com>**20110807004459
554 Ignore-this: 9a0dc7e5c74bfe840a9fce278619a103
555]
556[uri: add MDMF and MDMF directory caps, add extension hint support
557Kevan Carstensen <kevan@isnotajoke.com>**20110807004436
558 Ignore-this: 6486b7d4dc0e849c6b1e9cdfb6318eac
559]
560[test/test_mutable: tests for MDMF
561Kevan Carstensen <kevan@isnotajoke.com>**20110807004414
562 Ignore-this: 29f9c3a806d67df0ed09c4f0d857d347
563 
564 These are their own patch because they cut across a lot of the changes
565 I've made in implementing MDMF in such a way as to make it difficult to
566 split them up into the other patches.
567]
568[webapi changes for MDMF
569Kevan Carstensen <kevan@isnotajoke.com>**20110807004348
570 Ignore-this: d6d4dac680baa4c99b05882b3828796c
571 
572     - Learn how to create MDMF files and directories through the
573       mutable-type argument.
574     - Operate with the interface changes associated with MDMF and #993.
575     - Learn how to do partial updates of mutable files.
576]
577[mutable/servermap: Rework the servermap to work with MDMF mutable files
578Kevan Carstensen <kevan@isnotajoke.com>**20110807004259
579 Ignore-this: 154b987fa0af716c41185b88ff7ee2e1
580]
581[dirnode: teach dirnode to make MDMF directories
582Kevan Carstensen <kevan@isnotajoke.com>**20110807004224
583 Ignore-this: 765ccd6a07ff752bf6057a3dab9e5abd
584]
585[Fix some test failures caused by #393 patch.
586david-sarah@jacaranda.org**20110802032810
587 Ignore-this: 7f65e5adb5c859af289cea7011216fef
588]
589[docs: amend configuration, webapi documentation to talk about MDMF
590Kevan Carstensen <kevan@isnotajoke.com>**20110802022056
591 Ignore-this: 4cab9b7e4ab79cc1efdabe2d457f27a6
592]
593[cli: teach CLI how to create MDMF mutable files
594Kevan Carstensen <kevan@isnotajoke.com>**20110802021613
595 Ignore-this: 18d0ff98e75be231eed3c53319e76936
596 
597 Specifically, 'tahoe mkdir' and 'tahoe put' now take a --mutable-type
598 argument.
599]
600[frontends/sftpd: Resolve incompatibilities between SFTP frontend and MDMF changes
601Kevan Carstensen <kevan@isnotajoke.com>**20110802021207
602 Ignore-this: 5e0f6e961048f71d4eed6d30210ffd2e
603]
604[mutable/layout: Define MDMF share format, write tools for working with MDMF share format
605Kevan Carstensen <kevan@isnotajoke.com>**20110802021120
606 Ignore-this: fa76ef4800939e19ba3cbc22a2eab4e
607 
608 The changes in layout.py are mostly concerned with the MDMF share
609 format. In particular, we define read and write proxy objects used by
610 retrieval, publishing, and other code to write and read the MDMF share
611 format. We create equivalent proxies for SDMF objects so that these
612 objects can be suitably general.
613]
614[immutable/filenode: implement unified filenode interface
615Kevan Carstensen <kevan@isnotajoke.com>**20110802020905
616 Ignore-this: d9a442fc285157f134f5d1b4607c6a48
617]
618[immutable/literal.py: Implement interface changes in literal nodes.
619Kevan Carstensen <kevan@isnotajoke.com>**20110802020814
620 Ignore-this: 4371e71a50e65ce2607c4d67d3a32171
621]
622[test/common: Alter common test code to work with MDMF.
623Kevan Carstensen <kevan@isnotajoke.com>**20110802015643
624 Ignore-this: e564403182d0030439b168dd9f8726fa
625 
626 This mostly has to do with making the test code implement the new
627 unified filenode interfaces.
628]
629[mutable: train checker and repairer to work with MDMF mutable files
630Kevan Carstensen <kevan@isnotajoke.com>**20110802015140
631 Ignore-this: 8b1928925bed63708b71ab0de8d4306f
632]
633[nodemaker: teach nodemaker about MDMF caps
634Kevan Carstensen <kevan@isnotajoke.com>**20110802014926
635 Ignore-this: 430c73121b6883b99626cfd652fc65c4
636]
637[client: teach client how to create and work with MDMF files
638Kevan Carstensen <kevan@isnotajoke.com>**20110802014811
639 Ignore-this: d72fbc4c2ca63f00d9ab9dc2919098ff
640]
641[mutable/filenode: Modify mutable filenodes for use with MDMF
642Kevan Carstensen <kevan@isnotajoke.com>**20110802014501
643 Ignore-this: 3c230bb0ebe60a94c667b0ee0c3b28e0
644 
645 In particular:
646     - Break MutableFileNode and MutableFileVersion into distinct classes.
647     - Implement the interface modifications made for MDMF.
648     - Be aware of MDMF caps.
649     - Learn how to create and work with MDMF files.
650]
651[nodemaker: teach nodemaker how to create MDMF mutable files
652Kevan Carstensen <kevan@isnotajoke.com>**20110802014258
653 Ignore-this: 2bf1fd4f8c1d1ad0e855c678347b76c2
654]
655[interfaces: change interfaces to work with MDMF
656Kevan Carstensen <kevan@isnotajoke.com>**20110802014119
657 Ignore-this: 2f441022cf888c044bc9e6dd609db139
658 
659 A lot of this work concerns #993, in that it unifies (to an extent) the
660 interfaces of mutable and immutable files.
661]
662[mutable/publish: teach the publisher how to publish MDMF mutable files
663Kevan Carstensen <kevan@isnotajoke.com>**20110802013931
664 Ignore-this: 115217ec2b289452ec774cb725da8a86
665 
666 Like the downloader, the publisher needs some substantial changes to handle multiple segment mutable files.
667]
668[mutable/retrieve: rework the mutable downloader to handle multiple-segment files
669Kevan Carstensen <kevan@isnotajoke.com>**20110802013524
670 Ignore-this: 398d11b5cb993b50e5e4fa6e7a3856dc
671 
672 The downloader needs substantial reworking to handle multiple segment
673 mutable files, which it needs to handle for MDMF.
674]
675[Fix repeated 'the' in license text.
676david-sarah@jacaranda.org**20110819204836
677 Ignore-this: b3bd4e9ec22029fe15533ad2a60003ad
678]
679[Remove Non-Profit Open Software License from the set of 'added permission' licenses. Although it actually does qualify as an Open Source license (because it allows relicensing under plain OSL), its wording is unclear and could easily be misunderstood, and it contributes to incompatible license proliferation.
680david-sarah@jacaranda.org**20110819204742
681 Ignore-this: 7373819a6b5367581356728ea62cabb1
682]
683[docs: change links that pointed to COPYING.TGPPL.html to point to COPYING.TGPPL.rst instead
684zooko@zooko.com**20110819060142
685 Ignore-this: 301652554fd7ab4bfa5aa8f8a2863a9e
686]
687[docs: formatting: reflow to fill-column 77
688zooko@zooko.com**20110819060110
689 Ignore-this: ed1317c126f07c63b944bd2fa6aa2d21
690]
691[docs: formatting: M-x whitespace-cleanup
692zooko@zooko.com**20110819060041
693 Ignore-this: 8554b16a25067094d0dc4dc71e1b3950
694]
695[licensing: add to the list of licenses that we grant the added permission for
696zooko@zooko.com**20110819054656
697 Ignore-this: eb1490416ac6b7414a27f150a8a8a047
698 Added: most of the ones listed on the FSF's "List of Free Software, GPL Incompatible Licenses", plus the Non-Profit Open Software License.
699]
700[docs: reflow the added text at the top of COPYING.GPL to fill-column 77
701zooko@zooko.com**20110819053059
702 Ignore-this: e994ed6ffbcc12656406f11cb862ce99
703]
704[docs: reformat COPYING.TGPPL.html to COPYING.TGPPL.rst
705zooko@zooko.com**20110819052753
706 Ignore-this: 34ddf623e0a6de008ba859ca9c92b2fd
707]
708[docs: reflow docs/logging.rst to fill-column 77
709zooko@zooko.com**20110819044103
710 Ignore-this: a6901f2244995f278ddf8d75d29410bf
711]
712[doc: fix formatting error in docs/logging.rst
713zooko@zooko.com**20110819043946
714 Ignore-this: fa182dbbe7f4fda15e0a8bfcf7f00051
715]
716[Cleanups for suppression of UserWarnings. refs #1435
717david-sarah@jacaranda.org**20110818040749
718 Ignore-this: 3863ef399c1c382a1365d51f000d314c
719]
720[suppress warning emitted by newer zope.interface with Nevow 0.10
721zooko@zooko.com**20110817203134
722 Ignore-this: b86d4ce0ed1c0da76d1f9eaf8d08d9c4
723 refs #1435
724]
725[doc: formatting: reflow to fill-column=77
726zooko@zooko.com**20110809132510
727 Ignore-this: 2d6d2e203d52925968b4451f36364792
728]
729[allmydata/__init__.py, test_version.py: make version parsing understand '<=', with test. refs #1435
730david-sarah@jacaranda.org**20110815035153
731 Ignore-this: 8c3a75f4a2b42b56bac48b5053c5e9c2
732]
733[_auto_deps.py: change the requirement for zope.interface to <= 3.6.2, >= 3.6.6. fixes #1435
734david-sarah@jacaranda.org**20110815025347
735 Ignore-this: 17a88c0f6573f044fbcd6b666667bd37
736]
737[Makefile and setup.py: remove setup.py commands that we no longer need, and their uses in the Makefile. Delete a stale and incorrect comment about updating _version.py. Also fix some coding style checks in the Makefile to operate on all source files.
738david-sarah@jacaranda.org**20110801031952
739 Ignore-this: 80a435dee3bc6e29058d4b37ff579922
740]
741[remove misc/debian[_helpers], rely upon official packaging instead. fixes #1454
742warner@lothar.com**20110811182705
743 Ignore-this: 79673cafc7c108db49b5ab908d7b4668
744]
745[Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454
746david-sarah@jacaranda.org**20110801031857
747 Ignore-this: 347cbeff45757db630ce34d0cfb84f92
748]
749[replace tabs with spaces in the #1441 'tahoe debug' synopsis
750warner@lothar.com**20110811173704
751 Ignore-this: 513fbfb18a3dd93119ea3700118df7ee
752]
753[Correct the information printed by '/usr/bin/tahoe debug --help' on Debian/Ubuntu. fixes #1441
754david-sarah@jacaranda.org**20110724162530
755 Ignore-this: 30d4b8c20e420e9a9d1b73eba1113ae
756]
757[doc: edit the explanation of K-of-N tradeoffs
758zooko@zooko.com**20110804193409
759 Ignore-this: ab6f4e35a995c2099340b5c9c5d30f40
760]
761[doc: clean up formatting of doc/configuration.rst
762zooko@zooko.com**20110804192722
763 Ignore-this: 7a98a3a8afb7e5441ff1f534211199ba
764 reflow to 77 chars line width, M-x white-space cleanup, blank link between name and definition
765]
766[Add test for webopen. fixes #1149
767david-sarah@jacaranda.org**20110724211659
768 Ignore-this: 1e22853f7eb05e24c3141d56a513f661
769]
770[test_client.py: relax a check in test_create_drop_uploader so that it should pass on Python 2.4.x. refs #1429
771david-sarah@jacaranda.org**20110810052504
772 Ignore-this: 1380749ceaf33c30e26c50d57476616c
773]
774[test/common_util.py: correct fix to mkdir_nonascii. refs #1472
775david-sarah@jacaranda.org**20110810051906
776 Ignore-this: 93c0c33370bc47d95c26c4cce8e05290
777]
778[test/common_util.py: fix a typo. refs #1472
779david-sarah@jacaranda.org**20110810044235
780 Ignore-this: f88643d7c82cb3577686d77bbff9e2bc
781]
782[test_client.py, test_drop_upload.py: fix pyflakes warnings.
783david-sarah@jacaranda.org**20110810034505
784 Ignore-this: 1e2d71bf2f43d63cbb423d32a6f96793
785]
786[Factor out methods dealing with non-ASCII directories and filenames from test_drop_upload.py into common_util.py. refs #1429, #1472
787david-sarah@jacaranda.org**20110810031558
788 Ignore-this: 3de8f945fa7a58fc318a1184bad0fd1a
789]
790[test_client.py: add a test that the drop-uploader is initialized correctly by client.py. Also give the DropUploader service a name, which is necessary for the test. refs #1429
791david-sarah@jacaranda.org**20110810030538
792 Ignore-this: 13d511ea9bbe9da2dcffe4a91ce94eae
793]
794[drop-upload: rename 'start' method to 'startService', which is what you're supposed to use to start a Service. refs #1429
795david-sarah@jacaranda.org**20110810030345
796 Ignore-this: d1f5e5c63937ea37be37324e2f1ae99d
797]
798[test_drop_upload.py: add comment explaining why we don't use FilePath.setContent. refs #1429
799david-sarah@jacaranda.org**20110810025942
800 Ignore-this: b95358030b63cb467d1d7f1b9a9b6978
801]
802[test_drop_upload.py: fix some grammatical and spelling nits. refs #1429
803david-sarah@jacaranda.org**20110809221231
804 Ignore-this: fd331acddd9f754173f274a34fe62f03
805]
806[drop-upload: report the configured local directory being absent differently from it being a file
807zooko@zooko.com**20110809220930
808 Ignore-this: a08879100f5f20e609be3f0ffa3b25cc
809 refs #1429
810]
811[drop-upload: rename the 'upload.uri' parameter to 'upload.dircap', and a couple of cleanups to error messages. refs #1429
812zooko@zooko.com**20110809220508
813 Ignore-this: 4846368cbe331e8653bdce1f314e276b
814 I rerecorded this patch, originally by David-Sarah, to use "darcs replace" instead of editing to do the renames. This uncovered one missed rename in Client.init_drop_uploader. (Which also means that code isn't exercised by the current unit tests.)
815 refs #1429
816]
817[drop-upload test for non-existent local dir separately from test for non-directory local dir
818zooko@zooko.com**20110809220115
819 Ignore-this: cd85f345c02f5cb71b1c1527bd4ebddc
820 A candidate patch for #1429 has a bug when it is using FilePath.is_dir() to detect whether the configured local dir exists and is a directory. FilePath.is_dir() raises exception, instead of returning False, if the thing doesn't exist. This test is to make sure that DropUploader.__init__ raise different exceptions for those two cases.
821 refs #1429
822]
823[drop-upload: unit tests for the configuration options being named "cap" instead of "uri"
824zooko@zooko.com**20110809215913
825 Ignore-this: 958c78fffb3d76b3e4817647f824e7f9
826 This is a subset of a patch that David-Sarah attached to #1429. This is just the unit-tests part of that patch, and uses darcs record instead of hunks to change the names.
827 refs #1429
828]
829[src/allmydata/storage/server.py: use the filesystem of storage/shares/, rather than storage/, to calculate remaining space. fixes #1384
830david-sarah@jacaranda.org**20110719022752
831 Ignore-this: a4781043cfd453dbb66ae4f108d80bea
832]
833[test_storage.py: test that we are using the filesystem of storage/shares/, rather than storage/, to calculate remaining space, and that the HTML status output reflects the values returned by fileutil.get_disk_stats. This version works with older versions of the mock library. refs #1384
834david-sarah@jacaranda.org**20110809190722
835 Ignore-this: db447caca37a459ca49563efa58db58c
836]
837[Work around ref #1472 by having test_drop_upload delete the non-ASCII directories it creates.
838david-sarah@jacaranda.org**20110809012334
839 Ignore-this: 5881fd5db419ba8ad12e0b2a82f6c4f0
840]
841[Remove all trailing whitespace from .py files.
842david-sarah@jacaranda.org**20110809001117
843 Ignore-this: d2658b5ce44af70cc606ae4d3085b7cc
844]
845[test_drop_upload.py: fix unused imports. refs #1429
846david-sarah@jacaranda.org**20110808235422
847 Ignore-this: 834f6b946bfea699d7d8c743edd66671
848]
849[Documentation for drop-upload frontend. refs #1429
850david-sarah@jacaranda.org**20110808182146
851 Ignore-this: b33110834e586c0b784d1736c2af5779
852]
853[Drop-upload frontend, rerecorded for 1.9 beta (and correcting a minor mistake). Includes some fixes for Windows but not the Windows inotify implementation. fixes #1429
854david-sarah@jacaranda.org**20110808234049
855 Ignore-this: 67f824c7f554e9a3a85f9fd2e1123d97
856]
857[node.py: ensure that client and introducer nodes record their port number and use that port on the next restart, fixing a regression caused by #1385. fixes #1469.
858david-sarah@jacaranda.org**20110806221934
859 Ignore-this: 1aa9d340b6570320ab2f9edc89c9e0a8
860]
861[test_runner.py: fix a race condition in the test when NODE_URL_FILE is written before PORTNUM_FILE. refs #1469
862david-sarah@jacaranda.org**20110806231842
863 Ignore-this: ab01ae7cec3a073e29eec473e64052a0
864]
865[test_runner.py: cleanups of HOTLINE_FILE writing and removal.
866david-sarah@jacaranda.org**20110806231652
867 Ignore-this: 25f5c5d6f5d8faebb26a4ce80110a335
868]
869[test_runner.py: remove an unused constant.
870david-sarah@jacaranda.org**20110806221416
871 Ignore-this: eade2695cbabbea9cafeaa8debe410bb
872]
873[node.py: fix the error path for a missing config option so that it works for a Unicode base directory.
874david-sarah@jacaranda.org**20110806221007
875 Ignore-this: 4eb9cc04b2ce05182a274a0d69dafaf3
876]
877[test_runner.py: test that client and introducer nodes record their port number and use that port on the next restart. This tests for a regression caused by ref #1385.
878david-sarah@jacaranda.org**20110806220635
879 Ignore-this: 40a0c040b142dbddd47e69b3c3712f5
880]
881[test_runner.py: fix a bug in CreateNode.do_create introduced in changeset [5114] when the tahoe.cfg file has been written with CRLF line endings. refs #1385
882david-sarah@jacaranda.org**20110804003032
883 Ignore-this: 7b7afdcf99da6671afac2d42828883eb
884]
885[test_client.py: repair Basic.test_error_on_old_config_files. refs #1385
886david-sarah@jacaranda.org**20110803235036
887 Ignore-this: 31e2a9c3febe55948de7e144353663e
888]
889[test_checker.py: increase timeout for TooParallel.test_immutable again. The ARM buildslave took 38 seconds, so 40 seconds is too close to the edge; make it 80.
890david-sarah@jacaranda.org**20110803214042
891 Ignore-this: 2d8026a6b25534e01738f78d6c7495cb
892]
893[test_runner.py: fix RunNode.test_introducer to not rely on the mtime of introducer.furl to detect when the node has restarted. Instead we detect when node.url has been written. refs #1385
894david-sarah@jacaranda.org**20110803180917
895 Ignore-this: 11ddc43b107beca42cb78af88c5c394c
896]
897[Further improve error message about old config files. refs #1385
898david-sarah@jacaranda.org**20110803174546
899 Ignore-this: 9d6cc3c288d9863dce58faafb3855917
900]
901[Slightly improve error message about old config files (avoid unnecessary Unicode escaping). refs #1385
902david-sarah@jacaranda.org**20110803163848
903 Ignore-this: a3e3930fba7ccf90b8db3d2ed5829df4
904]
905[test_checker.py: increase timeout for TooParallel.test_immutable (was consistently failing on ARM buildslave).
906david-sarah@jacaranda.org**20110803163213
907 Ignore-this: d0efceaf12628e8791862b80c85b5d56
908]
909[Fix the bug that prevents an introducer from starting when introducer.furl already exists. Also remove some dead code that used to read old config files, and rename 'warn_about_old_config_files' to reflect that it's not a warning. refs #1385
910david-sarah@jacaranda.org**20110803013212
911 Ignore-this: 2d6cd14bd06a7493b26f2027aff78f4d
912]
913[test_runner.py: modify RunNode.test_introducer to test that starting an introducer works when the introducer.furl file already exists. refs #1385
914david-sarah@jacaranda.org**20110803012704
915 Ignore-this: 8cf7f27ac4bfbb5ad8ca4a974106d437
916]
917[verifier: correct a bug introduced in changeset [5106] that caused us to only verify the first block of a file. refs #1395
918david-sarah@jacaranda.org**20110802172437
919 Ignore-this: 87fb77854a839ff217dce73544775b11
920]
921[test_repairer: add a deterministic test of share data corruption that always flips the bits of the last byte of the share data. refs #1395
922david-sarah@jacaranda.org**20110802175841
923 Ignore-this: 72f54603785007e88220c8d979e08be7
924]
925[verifier: serialize the fetching of blocks within a share so that we don't use too much RAM
926zooko@zooko.com**20110802063703
927 Ignore-this: debd9bac07dcbb6803f835a9e2eabaa1
928 
929 Shares are still verified in parallel, but within a share, don't request a
930 block until the previous block has been verified and the memory we used to hold
931 it has been freed up.
932 
933 Patch originally due to Brian. This version has a mockery-patchery-style test
934 which is "low tech" (it implements the patching inline in the test code instead
935 of using an extension of the mock.patch() function from the mock library) and
936 which unpatches in case of exception.
937 
938 fixes #1395
939]
940[add docs about timing-channel attacks
941Brian Warner <warner@lothar.com>**20110802044541
942 Ignore-this: 73114d5f5ed9ce252597b707dba3a194
943]
944['test-coverage' now needs PYTHONPATH=. to find TOP/twisted/plugins/
945Brian Warner <warner@lothar.com>**20110802041952
946 Ignore-this: d40f1f4cb426ea1c362fc961baedde2
947]
948[remove nodeid from WriteBucketProxy classes and customers
949warner@lothar.com**20110801224317
950 Ignore-this: e55334bb0095de11711eeb3af827e8e8
951 refs #1363
952]
953[remove get_serverid() from ReadBucketProxy and customers, including Checker
954warner@lothar.com**20110801224307
955 Ignore-this: 837aba457bc853e4fd413ab1a94519cb
956 and debug.py dump-share commands
957 refs #1363
958]
959[reject old-style (pre-Tahoe-LAFS-v1.3) configuration files
960zooko@zooko.com**20110801232423
961 Ignore-this: b58218fcc064cc75ad8f05ed0c38902b
962 Check for the existence of any of them and if any are found raise exception which will abort the startup of the node.
963 This is a backwards-incompatible change for anyone who is still using old-style configuration files.
964 fixes #1385
965]
966[whitespace-cleanup
967zooko@zooko.com**20110725015546
968 Ignore-this: 442970d0545183b97adc7bd66657876c
969]
970[tests: use fileutil.write() instead of open() to ensure timely close even without CPython-style reference counting
971zooko@zooko.com**20110331145427
972 Ignore-this: 75aae4ab8e5fa0ad698f998aaa1888ce
973 Some of these already had an explicit close() but I went ahead and replaced them with fileutil.write() as well for the sake of uniformity.
974]
975[Address Kevan's comment in #776 about Options classes missed when adding 'self.command_name'. refs #776, #1359
976david-sarah@jacaranda.org**20110801221317
977 Ignore-this: 8881d42cf7e6a1d15468291b0cb8fab9
978]
979[docs/frontends/webapi.rst: change some more instances of 'delete' or 'remove' to 'unlink', change some section titles, and use two blank lines between all sections. refs #776, #1104
980david-sarah@jacaranda.org**20110801220919
981 Ignore-this: 572327591137bb05c24c44812d4b163f
982]
983[cleanup: implement rm as a synonym for unlink rather than vice-versa. refs #776
984david-sarah@jacaranda.org**20110801220108
985 Ignore-this: 598dcbed870f4f6bb9df62de9111b343
986]
987[docs/webapi.rst: address Kevan's comments about use of 'delete' on ref #1104
988david-sarah@jacaranda.org**20110801205356
989 Ignore-this: 4fbf03864934753c951ddeff64392491
990]
991[docs: some changes of 'delete' or 'rm' to 'unlink'. refs #1104
992david-sarah@jacaranda.org**20110713002722
993 Ignore-this: 304d2a330d5e6e77d5f1feed7814b21c
994]
995[WUI: change the label of the button to unlink a file from 'del' to 'unlink'. Also change some internal names to 'unlink', and allow 't=unlink' as a synonym for 't=delete' in the web-API interface. Incidentally, improve a test to check for the rename button as well as the unlink button. fixes #1104
996david-sarah@jacaranda.org**20110713001218
997 Ignore-this: 3eef6b3f81b94a9c0020a38eb20aa069
998]
999[src/allmydata/web/filenode.py: delete a stale comment that was made incorrect by changeset [3133].
1000david-sarah@jacaranda.org**20110801203009
1001 Ignore-this: b3912e95a874647027efdc97822dd10e
1002]
1003[fix typo introduced during rebasing of 'remove get_serverid from
1004Brian Warner <warner@lothar.com>**20110801200341
1005 Ignore-this: 4235b0f585c0533892193941dbbd89a8
1006 DownloadStatus.add_dyhb_request and customers' patch, to fix test failure.
1007]
1008[remove get_serverid from DownloadStatus.add_dyhb_request and customers
1009zooko@zooko.com**20110801185401
1010 Ignore-this: db188c18566d2d0ab39a80c9dc8f6be6
1011 This patch is a rebase of a patch originally written by Brian. I didn't change any of the intent of Brian's patch, just ported it to current trunk.
1012 refs #1363
1013]
1014[remove get_serverid from DownloadStatus.add_block_request and customers
1015zooko@zooko.com**20110801185344
1016 Ignore-this: 8bfa8201d6147f69b0fbe31beea9c1e
1017 This is a rebase of a patch Brian originally wrote. I haven't changed the intent of that patch, just ported it to trunk.
1018 refs #1363
1019]
1020[apply zooko's advice: storage_client get_known_servers() returns a frozenset, caller sorts
1021warner@lothar.com**20110801174452
1022 Ignore-this: 2aa13ea6cbed4e9084bd604bf8633692
1023 refs #1363
1024]
1025[test_immutable.Test: rewrite to use NoNetworkGrid, now takes 2.7s not 97s
1026warner@lothar.com**20110801174444
1027 Ignore-this: 54f30b5d7461d2b3514e2a0172f3a98c
1028 remove now-unused ShareManglingMixin
1029 refs #1363
1030]
1031[DownloadStatus.add_known_share wants to be used by Finder, web.status
1032warner@lothar.com**20110801174436
1033 Ignore-this: 1433bcd73099a579abe449f697f35f9
1034 refs #1363
1035]
1036[replace IServer.name() with get_name(), and get_longname()
1037warner@lothar.com**20110801174428
1038 Ignore-this: e5a6f7f6687fd7732ddf41cfdd7c491b
1039 
1040 This patch was originally written by Brian, but was re-recorded by Zooko to use
1041 darcs replace instead of hunks for any file in which it would result in fewer
1042 total hunks.
1043 refs #1363
1044]
1045[upload.py: apply David-Sarah's advice rename (un)contacted(2) trackers to first_pass/second_pass/next_pass
1046zooko@zooko.com**20110801174143
1047 Ignore-this: e36e1420bba0620a0107bd90032a5198
1048 This patch was written by Brian but was re-recorded by Zooko (with David-Sarah looking on) to use darcs replace instead of editing to rename the three variables to their new names.
1049 refs #1363
1050]
1051[Coalesce multiple Share.loop() calls, make downloads faster. Closes #1268.
1052Brian Warner <warner@lothar.com>**20110801151834
1053 Ignore-this: 48530fce36c01c0ff708f61c2de7e67a
1054]
1055[src/allmydata/_auto_deps.py: 'i686' is another way of spelling x86.
1056david-sarah@jacaranda.org**20110801034035
1057 Ignore-this: 6971e0621db2fba794d86395b4d51038
1058]
1059[tahoe_rm.py: better error message when there is no path. refs #1292
1060david-sarah@jacaranda.org**20110122064212
1061 Ignore-this: ff3bb2c9f376250e5fd77eb009e09018
1062]
1063[test_cli.py: Test for error message when 'tahoe rm' is invoked without a path. refs #1292
1064david-sarah@jacaranda.org**20110104105108
1065 Ignore-this: 29ec2f2e0251e446db96db002ad5dd7d
1066]
1067[src/allmydata/__init__.py: suppress a spurious warning from 'bin/tahoe --version[-and-path]' about twisted-web and twisted-core packages.
1068david-sarah@jacaranda.org**20110801005209
1069 Ignore-this: 50e7cd53cca57b1870d9df0361c7c709
1070]
1071[test_cli.py: use to_str on fields loaded using simplejson.loads in new tests. refs #1304
1072david-sarah@jacaranda.org**20110730032521
1073 Ignore-this: d1d6dfaefd1b4e733181bf127c79c00b
1074]
1075[cli: make 'tahoe cp' overwrite mutable files in-place
1076Kevan Carstensen <kevan@isnotajoke.com>**20110729202039
1077 Ignore-this: b2ad21a19439722f05c49bfd35b01855
1078]
1079[SFTP: write an error message to standard error for unrecognized shell commands. Change the existing message for shell sessions to be written to standard error, and refactor some duplicated code. Also change the lines of the error messages to end in CRLF, and take into account Kevan's review comments. fixes #1442, #1446
1080david-sarah@jacaranda.org**20110729233102
1081 Ignore-this: d2f2bb4664f25007d1602bf7333e2cdd
1082]
1083[src/allmydata/scripts/cli.py: fix pyflakes warning.
1084david-sarah@jacaranda.org**20110728021402
1085 Ignore-this: 94050140ddb99865295973f49927c509
1086]
1087[Fix the help synopses of CLI commands to include [options] in the right place. fixes #1359, fixes #636
1088david-sarah@jacaranda.org**20110724225440
1089 Ignore-this: 2a8e488a5f63dabfa9db9efd83768a5
1090]
1091[encodingutil: argv and output encodings are always the same on all platforms. Lose the unnecessary generality of them being different. fixes #1120
1092david-sarah@jacaranda.org**20110629185356
1093 Ignore-this: 5ebacbe6903dfa83ffd3ff8436a97787
1094]
1095[docs/man/tahoe.1: add man page. fixes #1420
1096david-sarah@jacaranda.org**20110724171728
1097 Ignore-this: fc7601ec7f25494288d6141d0ae0004c
1098]
1099[Update the dependency on zope.interface to fix an incompatiblity between Nevow and zope.interface 3.6.4. fixes #1435
1100david-sarah@jacaranda.org**20110721234941
1101 Ignore-this: 2ff3fcfc030fca1a4d4c7f1fed0f2aa9
1102]
1103[frontends/ftpd.py: remove the check for IWriteFile.close since we're now guaranteed to be using Twisted >= 10.1 which has it.
1104david-sarah@jacaranda.org**20110722000320
1105 Ignore-this: 55cd558b791526113db3f83c00ec328a
1106]
1107[Update the dependency on Twisted to >= 10.1. This allows us to simplify some documentation: it's no longer necessary to install pywin32 on Windows, or apply a patch to Twisted in order to use the FTP frontend. fixes #1274, #1438. refs #1429
1108david-sarah@jacaranda.org**20110721233658
1109 Ignore-this: 81b41745477163c9b39c0b59db91cc62
1110]
1111[misc/build_helpers/run_trial.py: undo change to block pywin32 (it didn't work because run_trial.py is no longer used). refs #1334
1112david-sarah@jacaranda.org**20110722035402
1113 Ignore-this: 5d03f544c4154f088e26c7107494bf39
1114]
1115[misc/build_helpers/run_trial.py: ensure that pywin32 is not on the sys.path when running the test suite. Includes some temporary debugging printouts that will be removed. refs #1334
1116david-sarah@jacaranda.org**20110722024907
1117 Ignore-this: 5141a9f83a4085ed4ca21f0bbb20bb9c
1118]
1119[docs/running.rst: use 'tahoe run ~/.tahoe' instead of 'tahoe run' (the default is the current directory, unlike 'tahoe start').
1120david-sarah@jacaranda.org**20110718005949
1121 Ignore-this: 81837fbce073e93d88a3e7ae3122458c
1122]
1123[docs/running.rst: say to put the introducer.furl in tahoe.cfg.
1124david-sarah@jacaranda.org**20110717194315
1125 Ignore-this: 954cc4c08e413e8c62685d58ff3e11f3
1126]
1127[README.txt: say that quickstart.rst is in the docs directory.
1128david-sarah@jacaranda.org**20110717192400
1129 Ignore-this: bc6d35a85c496b77dbef7570677ea42a
1130]
1131[setup: remove the dependency on foolscap's "secure_connections" extra, add a dependency on pyOpenSSL
1132zooko@zooko.com**20110717114226
1133 Ignore-this: df222120d41447ce4102616921626c82
1134 fixes #1383
1135]
1136[test_sftp.py cleanup: remove a redundant definition of failUnlessReallyEqual.
1137david-sarah@jacaranda.org**20110716181813
1138 Ignore-this: 50113380b368c573f07ac6fe2eb1e97f
1139]
1140[docs: add missing link in NEWS.rst
1141zooko@zooko.com**20110712153307
1142 Ignore-this: be7b7eb81c03700b739daa1027d72b35
1143]
1144[contrib: remove the contributed fuse modules and the entire contrib/ directory, which is now empty
1145zooko@zooko.com**20110712153229
1146 Ignore-this: 723c4f9e2211027c79d711715d972c5
1147 Also remove a couple of vestigial references to figleaf, which is long gone.
1148 fixes #1409 (remove contrib/fuse)
1149]
1150[add Protovis.js-based download-status timeline visualization
1151Brian Warner <warner@lothar.com>**20110629222606
1152 Ignore-this: 477ccef5c51b30e246f5b6e04ab4a127
1153 
1154 provide status overlap info on the webapi t=json output, add decode/decrypt
1155 rate tooltips, add zoomin/zoomout buttons
1156]
1157[add more download-status data, fix tests
1158Brian Warner <warner@lothar.com>**20110629222555
1159 Ignore-this: e9e0b7e0163f1e95858aa646b9b17b8c
1160]
1161[prepare for viz: improve DownloadStatus events
1162Brian Warner <warner@lothar.com>**20110629222542
1163 Ignore-this: 16d0bde6b734bb501aa6f1174b2b57be
1164 
1165 consolidate IDownloadStatusHandlingConsumer stuff into DownloadNode
1166]
1167[docs: fix error in crypto specification that was noticed by Taylor R Campbell <campbell+tahoe@mumble.net>
1168zooko@zooko.com**20110629185711
1169 Ignore-this: b921ed60c1c8ba3c390737fbcbe47a67
1170]
1171[setup.py: don't make bin/tahoe.pyscript executable. fixes #1347
1172david-sarah@jacaranda.org**20110130235809
1173 Ignore-this: 3454c8b5d9c2c77ace03de3ef2d9398a
1174]
1175[Makefile: remove targets relating to 'setup.py check_auto_deps' which no longer exists. fixes #1345
1176david-sarah@jacaranda.org**20110626054124
1177 Ignore-this: abb864427a1b91bd10d5132b4589fd90
1178]
1179[Makefile: add 'make check' as an alias for 'make test'. Also remove an unnecessary dependency of 'test' on 'build' and 'src/allmydata/_version.py'. fixes #1344
1180david-sarah@jacaranda.org**20110623205528
1181 Ignore-this: c63e23146c39195de52fb17c7c49b2da
1182]
1183[Rename test_package_initialization.py to (much shorter) test_import.py .
1184Brian Warner <warner@lothar.com>**20110611190234
1185 Ignore-this: 3eb3dbac73600eeff5cfa6b65d65822
1186 
1187 The former name was making my 'ls' listings hard to read, by forcing them
1188 down to just two columns.
1189]
1190[tests: fix tests to accomodate [20110611153758-92b7f-0ba5e4726fb6318dac28fb762a6512a003f4c430]
1191zooko@zooko.com**20110611163741
1192 Ignore-this: 64073a5f39e7937e8e5e1314c1a302d1
1193 Apparently none of the two authors (stercor, terrell), three reviewers (warner, davidsarah, terrell), or one committer (me) actually ran the tests. This is presumably due to #20.
1194 fixes #1412
1195]
1196[wui: right-align the size column in the WUI
1197zooko@zooko.com**20110611153758
1198 Ignore-this: 492bdaf4373c96f59f90581c7daf7cd7
1199 Thanks to Ted "stercor" Rolle Jr. and Terrell Russell.
1200 fixes #1412
1201]
1202[docs: three minor fixes
1203zooko@zooko.com**20110610121656
1204 Ignore-this: fec96579eb95aceb2ad5fc01a814c8a2
1205 CREDITS for arc for stats tweak
1206 fix link to .zip file in quickstart.rst (thanks to ChosenOne for noticing)
1207 English usage tweak
1208]
1209[docs/running.rst: fix stray HTML (not .rst) link noticed by ChosenOne.
1210david-sarah@jacaranda.org**20110609223719
1211 Ignore-this: fc50ac9c94792dcac6f1067df8ac0d4a
1212]
1213[server.py:  get_latencies now reports percentiles _only_ if there are sufficient observations for the interpretation of the percentile to be unambiguous.
1214wilcoxjg@gmail.com**20110527120135
1215 Ignore-this: 2e7029764bffc60e26f471d7c2b6611e
1216 interfaces.py:  modified the return type of RIStatsProvider.get_stats to allow for None as a return value
1217 NEWS.rst, stats.py: documentation of change to get_latencies
1218 stats.rst: now documents percentile modification in get_latencies
1219 test_storage.py:  test_latencies now expects None in output categories that contain too few samples for the associated percentile to be unambiguously reported.
1220 fixes #1392
1221]
1222[docs: revert link in relnotes.txt from NEWS.rst to NEWS, since the former did not exist at revision 5000.
1223david-sarah@jacaranda.org**20110517011214
1224 Ignore-this: 6a5be6e70241e3ec0575641f64343df7
1225]
1226[docs: convert NEWS to NEWS.rst and change all references to it.
1227david-sarah@jacaranda.org**20110517010255
1228 Ignore-this: a820b93ea10577c77e9c8206dbfe770d
1229]
1230[docs: remove out-of-date docs/testgrid/introducer.furl and containing directory. fixes #1404
1231david-sarah@jacaranda.org**20110512140559
1232 Ignore-this: 784548fc5367fac5450df1c46890876d
1233]
1234[scripts/common.py: don't assume that the default alias is always 'tahoe' (it is, but the API of get_alias doesn't say so). refs #1342
1235david-sarah@jacaranda.org**20110130164923
1236 Ignore-this: a271e77ce81d84bb4c43645b891d92eb
1237]
1238[setup: don't catch all Exception from check_requirement(), but only PackagingError and ImportError
1239zooko@zooko.com**20110128142006
1240 Ignore-this: 57d4bc9298b711e4bc9dc832c75295de
1241 I noticed this because I had accidentally inserted a bug which caused AssertionError to be raised from check_requirement().
1242]
1243[M-x whitespace-cleanup
1244zooko@zooko.com**20110510193653
1245 Ignore-this: dea02f831298c0f65ad096960e7df5c7
1246]
1247[docs: fix typo in running.rst, thanks to arch_o_median
1248zooko@zooko.com**20110510193633
1249 Ignore-this: ca06de166a46abbc61140513918e79e8
1250]
1251[relnotes.txt: don't claim to work on Cygwin (which has been untested for some time). refs #1342
1252david-sarah@jacaranda.org**20110204204902
1253 Ignore-this: 85ef118a48453d93fa4cddc32d65b25b
1254]
1255[relnotes.txt: forseeable -> foreseeable. refs #1342
1256david-sarah@jacaranda.org**20110204204116
1257 Ignore-this: 746debc4d82f4031ebf75ab4031b3a9
1258]
1259[replace remaining .html docs with .rst docs
1260zooko@zooko.com**20110510191650
1261 Ignore-this: d557d960a986d4ac8216d1677d236399
1262 Remove install.html (long since deprecated).
1263 Also replace some obsolete references to install.html with references to quickstart.rst.
1264 Fix some broken internal references within docs/historical/historical_known_issues.txt.
1265 Thanks to Ravi Pinjala and Patrick McDonald.
1266 refs #1227
1267]
1268[docs: FTP-and-SFTP.rst: fix a minor error and update the information about which version of Twisted fixes #1297
1269zooko@zooko.com**20110428055232
1270 Ignore-this: b63cfb4ebdbe32fb3b5f885255db4d39
1271]
1272[munin tahoe_files plugin: fix incorrect file count
1273francois@ctrlaltdel.ch**20110428055312
1274 Ignore-this: 334ba49a0bbd93b4a7b06a25697aba34
1275 fixes #1391
1276]
1277[corrected "k must never be smaller than N" to "k must never be greater than N"
1278secorp@allmydata.org**20110425010308
1279 Ignore-this: 233129505d6c70860087f22541805eac
1280]
1281[Fix a test failure in test_package_initialization on Python 2.4.x due to exceptions being stringified differently than in later versions of Python. refs #1389
1282david-sarah@jacaranda.org**20110411190738
1283 Ignore-this: 7847d26bc117c328c679f08a7baee519
1284]
1285[tests: add test for including the ImportError message and traceback entry in the summary of errors from importing dependencies. refs #1389
1286david-sarah@jacaranda.org**20110410155844
1287 Ignore-this: fbecdbeb0d06a0f875fe8d4030aabafa
1288]
1289[allmydata/__init__.py: preserve the message and last traceback entry (file, line number, function, and source line) of ImportErrors in the package versions string. fixes #1389
1290david-sarah@jacaranda.org**20110410155705
1291 Ignore-this: 2f87b8b327906cf8bfca9440a0904900
1292]
1293[remove unused variable detected by pyflakes
1294zooko@zooko.com**20110407172231
1295 Ignore-this: 7344652d5e0720af822070d91f03daf9
1296]
1297[allmydata/__init__.py: Nicer reporting of unparseable version numbers in dependencies. fixes #1388
1298david-sarah@jacaranda.org**20110401202750
1299 Ignore-this: 9c6bd599259d2405e1caadbb3e0d8c7f
1300]
1301[update FTP-and-SFTP.rst: the necessary patch is included in Twisted-10.1
1302Brian Warner <warner@lothar.com>**20110325232511
1303 Ignore-this: d5307faa6900f143193bfbe14e0f01a
1304]
1305[control.py: remove all uses of s.get_serverid()
1306warner@lothar.com**20110227011203
1307 Ignore-this: f80a787953bd7fa3d40e828bde00e855
1308]
1309[web: remove some uses of s.get_serverid(), not all
1310warner@lothar.com**20110227011159
1311 Ignore-this: a9347d9cf6436537a47edc6efde9f8be
1312]
1313[immutable/downloader/fetcher.py: remove all get_serverid() calls
1314warner@lothar.com**20110227011156
1315 Ignore-this: fb5ef018ade1749348b546ec24f7f09a
1316]
1317[immutable/downloader/fetcher.py: fix diversity bug in server-response handling
1318warner@lothar.com**20110227011153
1319 Ignore-this: bcd62232c9159371ae8a16ff63d22c1b
1320 
1321 When blocks terminate (either COMPLETE or CORRUPT/DEAD/BADSEGNUM), the
1322 _shares_from_server dict was being popped incorrectly (using shnum as the
1323 index instead of serverid). I'm still thinking through the consequences of
1324 this bug. It was probably benign and really hard to detect. I think it would
1325 cause us to incorrectly believe that we're pulling too many shares from a
1326 server, and thus prefer a different server rather than asking for a second
1327 share from the first server. The diversity code is intended to spread out the
1328 number of shares simultaneously being requested from each server, but with
1329 this bug, it might be spreading out the total number of shares requested at
1330 all, not just simultaneously. (note that SegmentFetcher is scoped to a single
1331 segment, so the effect doesn't last very long).
1332]
1333[immutable/downloader/share.py: reduce get_serverid(), one left, update ext deps
1334warner@lothar.com**20110227011150
1335 Ignore-this: d8d56dd8e7b280792b40105e13664554
1336 
1337 test_download.py: create+check MyShare instances better, make sure they share
1338 Server objects, now that finder.py cares
1339]
1340[immutable/downloader/finder.py: reduce use of get_serverid(), one left
1341warner@lothar.com**20110227011146
1342 Ignore-this: 5785be173b491ae8a78faf5142892020
1343]
1344[immutable/offloaded.py: reduce use of get_serverid() a bit more
1345warner@lothar.com**20110227011142
1346 Ignore-this: b48acc1b2ae1b311da7f3ba4ffba38f
1347]
1348[immutable/upload.py: reduce use of get_serverid()
1349warner@lothar.com**20110227011138
1350 Ignore-this: ffdd7ff32bca890782119a6e9f1495f6
1351]
1352[immutable/checker.py: remove some uses of s.get_serverid(), not all
1353warner@lothar.com**20110227011134
1354 Ignore-this: e480a37efa9e94e8016d826c492f626e
1355]
1356[add remaining get_* methods to storage_client.Server, NoNetworkServer, and
1357warner@lothar.com**20110227011132
1358 Ignore-this: 6078279ddf42b179996a4b53bee8c421
1359 MockIServer stubs
1360]
1361[upload.py: rearrange _make_trackers a bit, no behavior changes
1362warner@lothar.com**20110227011128
1363 Ignore-this: 296d4819e2af452b107177aef6ebb40f
1364]
1365[happinessutil.py: finally rename merge_peers to merge_servers
1366warner@lothar.com**20110227011124
1367 Ignore-this: c8cd381fea1dd888899cb71e4f86de6e
1368]
1369[test_upload.py: factor out FakeServerTracker
1370warner@lothar.com**20110227011120
1371 Ignore-this: 6c182cba90e908221099472cc159325b
1372]
1373[test_upload.py: server-vs-tracker cleanup
1374warner@lothar.com**20110227011115
1375 Ignore-this: 2915133be1a3ba456e8603885437e03
1376]
1377[happinessutil.py: server-vs-tracker cleanup
1378warner@lothar.com**20110227011111
1379 Ignore-this: b856c84033562d7d718cae7cb01085a9
1380]
1381[upload.py: more tracker-vs-server cleanup
1382warner@lothar.com**20110227011107
1383 Ignore-this: bb75ed2afef55e47c085b35def2de315
1384]
1385[upload.py: fix var names to avoid confusion between 'trackers' and 'servers'
1386warner@lothar.com**20110227011103
1387 Ignore-this: 5d5e3415b7d2732d92f42413c25d205d
1388]
1389[refactor: s/peer/server/ in immutable/upload, happinessutil.py, test_upload
1390warner@lothar.com**20110227011100
1391 Ignore-this: 7ea858755cbe5896ac212a925840fe68
1392 
1393 No behavioral changes, just updating variable/method names and log messages.
1394 The effects outside these three files should be minimal: some exception
1395 messages changed (to say "server" instead of "peer"), and some internal class
1396 names were changed. A few things still use "peer" to minimize external
1397 changes, like UploadResults.timings["peer_selection"] and
1398 happinessutil.merge_peers, which can be changed later.
1399]
1400[storage_client.py: clean up test_add_server/test_add_descriptor, remove .test_servers
1401warner@lothar.com**20110227011056
1402 Ignore-this: efad933e78179d3d5fdcd6d1ef2b19cc
1403]
1404[test_client.py, upload.py:: remove KiB/MiB/etc constants, and other dead code
1405warner@lothar.com**20110227011051
1406 Ignore-this: dc83c5794c2afc4f81e592f689c0dc2d
1407]
1408[test: increase timeout on a network test because Francois's ARM machine hit that timeout
1409zooko@zooko.com**20110317165909
1410 Ignore-this: 380c345cdcbd196268ca5b65664ac85b
1411 I'm skeptical that the test was proceeding correctly but ran out of time. It seems more likely that it had gotten hung. But if we raise the timeout to an even more extravagant number then we can be even more certain that the test was never going to finish.
1412]
1413[docs/configuration.rst: add a "Frontend Configuration" section
1414Brian Warner <warner@lothar.com>**20110222014323
1415 Ignore-this: 657018aa501fe4f0efef9851628444ca
1416 
1417 this points to docs/frontends/*.rst, which were previously underlinked
1418]
1419[web/filenode.py: avoid calling req.finish() on closed HTTP connections. Closes #1366
1420"Brian Warner <warner@lothar.com>"**20110221061544
1421 Ignore-this: 799d4de19933f2309b3c0c19a63bb888
1422]
1423[Add unit tests for cross_check_pkg_resources_versus_import, and a regression test for ref #1355. This requires a little refactoring to make it testable.
1424david-sarah@jacaranda.org**20110221015817
1425 Ignore-this: 51d181698f8c20d3aca58b057e9c475a
1426]
1427[allmydata/__init__.py: .name was used in place of the correct .__name__ when printing an exception. Also, robustify string formatting by using %r instead of %s in some places. fixes #1355.
1428david-sarah@jacaranda.org**20110221020125
1429 Ignore-this: b0744ed58f161bf188e037bad077fc48
1430]
1431[Refactor StorageFarmBroker handling of servers
1432Brian Warner <warner@lothar.com>**20110221015804
1433 Ignore-this: 842144ed92f5717699b8f580eab32a51
1434 
1435 Pass around IServer instance instead of (peerid, rref) tuple. Replace
1436 "descriptor" with "server". Other replacements:
1437 
1438  get_all_servers -> get_connected_servers/get_known_servers
1439  get_servers_for_index -> get_servers_for_psi (now returns IServers)
1440 
1441 This change still needs to be pushed further down: lots of code is now
1442 getting the IServer and then distributing (peerid, rref) internally.
1443 Instead, it ought to distribute the IServer internally and delay
1444 extracting a serverid or rref until the last moment.
1445 
1446 no_network.py was updated to retain parallelism.
1447]
1448[TAG allmydata-tahoe-1.8.2
1449warner@lothar.com**20110131020101]
1450Patch bundle hash:
1451d39767f0ce56894ce539c5a7971c119c9ec1c878