Ticket #1366: 1366-no-hasattr.darcs.patch

1 patch for repository davidsarah@dev.allmydata.org:/home/darcs/tahoe/trunk:

Thu Oct 13 21:03:44 BST 2011  david-sarah@jacaranda.org
  * web/filenode.py: since we depend on Twisted >= 10.1, there is no need to check for the existence of 'req.notifyFinish', which was added in Twisted 9.0. closes #1366

New patches:

[web/filenode.py: since we depend on Twisted >= 10.1, there is no need to check for the existence of 'req.notifyFinish', which was added in Twisted 9.0. closes #1366
david-sarah@jacaranda.org**20111013200344
 Ignore-this: 72399daa19a5a5076c12453b631cd547
] hunk ./src/allmydata/web/filenode.py 460
         finished = []
         def _request_finished(ign):
             finished.append(True)
-        if hasattr(req, "notifyFinish"):
-            req.notifyFinish().addBoth(_request_finished)
+        req.notifyFinish().addBoth(_request_finished)
 
         d = self.filenode.read(req, first, size)
 

Context:

[docs: fix several imprecise or inaccurate values in performance.rst
zooko@zooko.com**20110508124228
 Ignore-this: f1ecc5cb32eebec9760c8fc437799eb4
 add cpu values for each operation
 sort the list of values into the same order in each operation
 refs #1398
] 
[oops, missed a test failure
Brian Warner <warner@lothar.com>**20111013163713
 Ignore-this: d8cb188d8dd664e335f19b9fa342da4a
] 
[misc mutable-type fixes:
warner@lothar.com**20111013163229
 Ignore-this: ab62dc2f27aa1f793e7bd02e360ee471
 
 * fix tahoe.cfg control of default mutable type
 * tolerate arbitrary case in [client]mutable.format value
 * small docs improvements
 * use get_mutable_type() as a format-is-mutable predicate
 * tighten up error message
] 
[webapi: use all-caps "SDMF"/"MDMF" acronyms in t=json response
warner@lothar.com**20111013163143
 Ignore-this: 945eaa5ce7f108793b0bb6cae0239965
 
 docs: upcase examples of t=json output and format= input
] 
[webapi.rst: fix whitespace (detabify) t=json examples
warner@lothar.com**20111013163056
 Ignore-this: c095687413876507c5cc46864459c054
] 
[webapi: handle format=, remove mutable-type=
warner@lothar.com**20111013162951
 Ignore-this: de7d9c5516385d002dbc21f31c23204c
 
 * fix CLI commands (put, mkdir) to send format=, not mutable-type=
 * fix tests
 * test_cli: fix tests that observe t=json output, don't ignore failures in
   'tahoe put'
 * fix handling of version= to make it easier to use the default
 * interpret ?mutable=true&format=MDMF as MDMF, not SDMF
] 
[docs/frontends/webapi.rst: document the format argument
kevan@isnotajoke.com**20111010025529
 Ignore-this: 2a7b8d711dc369bd9a23e2853824cfb0
] 
[Tests for ref #1547
david-sarah@jacaranda.org**20111002035316
 Ignore-this: 933f2b6ff148523f40475fe2d2578170
] 
[Change the file upload forms on directory and welcome pages to use a 3-way radio button to select immutable, SDMF, or MDMF. Add '(experimental)' to the label for creating an MDMF directory. Also improve the spacing of form elements. refs #1547
david-sarah@jacaranda.org**20111002034503
 Ignore-this: 46a8b966fddc8ccaa7e70bffbd68b52f
] 
[test_web.py: minor cleanups, mainly to make the first argument to shouldFail tests consistent
david-sarah@jacaranda.org**20111002040332
 Ignore-this: 234ba793f78f112717e02755e1fa81b5
] 
[Tests for ref #1552
david-sarah@jacaranda.org**20111002040036
 Ignore-this: abdc5c39d90ea7f314834fff7ecd6784
] 
[misc/check-interfaces.py: print a warning if a .pyc or .pyo file exists without a corresponding .py file.
david-sarah@jacaranda.org**20111012233609
 Ignore-this: 35f04939360c6d3b1e8e0c2e9e712d80
] 
[test/common.py: in shouldFail and shouldHTTPError, when the raised exception does not include the expected substring (or, for shouldHTTPError, when the status code is wrong), mention which test that happened in.
david-sarah@jacaranda.org**20111011002227
 Ignore-this: 836cabe9ef774617122905b214a0b8e8
] 
[interfaces.py: remove get_extension_params and set_extension_params methods from IMutableFileURI. refs #393, #1526
david-sarah@jacaranda.org**20111010194842
 Ignore-this: 6012be6fcc12f560aeeeac0be2d337d1
] 
[interfaces.py: fix a typo in the name of IMutableSlotWriter.put_encprivkey. refs #393
david-sarah@jacaranda.org**20111010194642
 Ignore-this: eb65439e8dd891c169b43b1679c29238
] 
[util/happinessutil.py: suppress a warning from check-miscaptures. (It is not a bug because the capturing function is only used by a 'map' in the same iteration.) refs #1556
david-sarah@jacaranda.org**20111009052106
 Ignore-this: 16a62844bae083800d6b6a7334abc9bc
] 
[misc/coding_tools/make-canary-files.py: fix a suspicious capture reported by check-miscaptures (although it happens not to be a bug because the callback will be processed synchronously). refs #1556
david-sarah@jacaranda.org**20111009050531
 Ignore-this: 2d1a696955a4c1f7d9c649d4ecefd7de
] 
[Fix some more potential bugs in test code exposed by check-miscaptures.py. refs #1556
david-sarah@jacaranda.org**20111007033847
 Ignore-this: aec8a543e9b5c3563b60692c647439a8
] 
[Fix some potential bugs (in non-test code) exposed by check-miscaptures.py. refs #1556
david-sarah@jacaranda.org**20111007032444
 Ignore-this: bac9ed65b21c2136c4db2482b3c093f7
] 
[Fix some potential bugs in test code exposed by check-miscaptures.py. refs #1556
david-sarah@jacaranda.org**20111007023443
 Ignore-this: e48b2c2d200521d6f28c737994ce3a2a
] 
[misc/simulators/hashbasedsig.py: simplify by removing unnecessary local function that captured a variable declared in a for loop (this was not a bug, but the code was unclear). Also fix a pyflakes warning about an import. refs #1556
david-sarah@jacaranda.org**20111007023001
 Ignore-this: 446c94efae02ded5e85eb3335ca5e69
] 
[immutable/literal.py: add pauseProducing method to LiteralProducer. refs #1537
david-sarah@jacaranda.org**20111003195239
 Ignore-this: 385ee3379a2819381937357f1eac457
] 
[no_network.py: Clean up whitespace around code changed by previous patch.
david-sarah@jacaranda.org**20111004010407
 Ignore-this: 647ec8a9346dca1a41212ab250619b72
] 
[no_network.py: Fix potential bugs in some tests due to capture of slots in for loops.
david-sarah@jacaranda.org**20111004010231
 Ignore-this: 9c496877613a3befd54979e5de6e63d2
] 
[docs: fix the rst formatting of COPYING.TGPPL.rst
zooko@zooko.com**20111003043333
 Ignore-this: c5fbc83f4a3db81a0c95b27053c463c5
 Now it renders correctly both on trac and with rst2html --verbose from docutils v0.8.1.
] 
[MDMF: remove extension fields from caps, tolerate arbitrary ones. Fixes #1526
Brian Warner <warner@lothar.com>**20111001233553
 Ignore-this: 335e1690aef1146a2c0b8d8c18c1cb21
 
 The filecaps used to be produced with hints for 'k' and segsize, but they
 weren't actually used, and doing so had the potential to limit how we change
 those filecaps in the future. Also the parsing code had some problems dealing
 with other numbers of extensions. Removing the existing fields and making the
 parser tolerate (and ignore) extra ones makes MDMF more future-proof.
] 
[test/test_runner.py: BinTahoe.test_path has rare nondeterministic failures; this patch probably fixes a problem where the actual cause of failure is masked by a string conversion error.
david-sarah@jacaranda.org**20110927225336
 Ignore-this: 6f1ad68004194cc9cea55ace3745e4af
] 
[docs/configuration.rst: add section about the types of node, and clarify when setting web.port enables web-API service. fixes #1444
zooko@zooko.com**20110926203801
 Ignore-this: ab94d470c68e720101a7ff3c207a719e
] 
[TAG allmydata-tahoe-1.9.0a2
warner@lothar.com**20110925234811
 Ignore-this: e9649c58f9c9017a7d55008938dba64f
] 
Patch bundle hash:
b7b833a83d53252606437d808f848f9167a15877