Ticket #1232: workaround-windows-writeconsole-suckage.darcs.patch

File workaround-windows-writeconsole-suckage.darcs.patch, 5.3 KB (added by davidsarah, at 2010-10-27T02:42:39Z)

windows/fixups.py: limit length of string passed in a single call to WriteConsoleW. fixes #1232.

Line 
11 patch for repository davidsarah@dev.allmydata.org:/home/darcs/tahoe/trunk:
2
3Wed Oct 27 03:16:36 GMT Daylight Time 2010  david-sarah@jacaranda.org
4  * windows/fixups.py: limit length of string passed in a single call to WriteConsoleW. fixes #1232.
5
6New patches:
7
8[windows/fixups.py: limit length of string passed in a single call to WriteConsoleW. fixes #1232.
9david-sarah@jacaranda.org**20101027021636
10 Ignore-this: fbd99e0d22493974696d37925d97c7d6
11] hunk ./src/allmydata/windows/fixups.py 132
12                             remaining = len(text)
13                             while remaining > 0:
14                                 n = DWORD(0)
15-                                retval = WriteConsoleW(self._hConsole, text, remaining, byref(n), None)
16+                                # There is a shorter-than-documented limitation on the length of the string
17+                                # passed to WriteConsoleW (see #1232).
18+                                retval = WriteConsoleW(self._hConsole, text, min(remaining, 10000), byref(n), None)
19                                 if retval == 0 or n.value == 0:
20                                     raise IOError("WriteConsoleW returned %r, n.value = %r" % (retval, n.value))
21                                 remaining -= n.value
22
23Context:
24
25[docs/known_issues.rst: Add section on traffic analysis. Fix URL for current version of file.
26david-sarah@jacaranda.org**20101024234259
27 Ignore-this: f3416e79d3bb833f5118da23e85723ad
28]
29[test_mutable.py: add test for ResponseCache memory leak. refs #1045, #1129
30david-sarah@jacaranda.org**20101024193409
31 Ignore-this: 3aee7f0677956cc6deaccb4d5b8e415f
32]
33[docs/running.html: fix missing end-quote, and change frontends/ doc references to .rst.
34david-sarah@jacaranda.org**20101024171500
35 Ignore-this: 47c645a6595e1790b1d1adfa71af0e1d
36]
37[docs/running.html: 'tahoe create-client' now creates a node with storage disabled. Also change configuration.txt references to configuration.rst.
38david-sarah@jacaranda.org**20101024170431
39 Ignore-this: e5b048055494ba3505bb8a506610681c
40]
41[test_encodingutil.py: test_argv_to_unicode modified the wrong encoding variable. fixes #1214
42david-sarah@jacaranda.org**20101023035810
43 Ignore-this: e5f1f849931b96939facc53d93ff61c5
44]
45[doc: add explanation of the motivation for the surprising and awkward API to erasure coding
46zooko@zooko.com**20101015060202
47 Ignore-this: 428913ff6e1bf5b393deffb1f20b949b
48]
49[setup: catch and log ValueError from locale.getdefaultlocale() in show-tool-versions.py
50zooko@zooko.com**20101015054440
51 Ignore-this: 827d91490562c32ed7cf6526dfded773
52 I got a bug report from Mathias Baert showing that locale.getdefaultlocale() raises an exception on his Mac OS X system. Heh.
53]
54[docs: update how-to-make-a-release doc with a few tweaks from the 1.8.0 process
55zooko@zooko.com**20101015054413
56 Ignore-this: ca5e9478531a3393792ae283239549dd
57]
58[docs: update NEWS ref: #1216
59zooko@zooko.com**20101015053719
60 Ignore-this: 2e0b92e4145d667cdf075e64b7965530
61]
62[docs: fix tab-vs-spaces, make some CLI examples <tt>/"literal", wrap some to
63Brian Warner <warner@lothar.com>**20101015060606
64 Ignore-this: eae08bdf0afb19a2fbf41c31e70a8122
65 80-cols, remove spurious whitespace. Add rst2html.py rule to Makefile.
66]
67[docs: add Peter Secor, Shawn Willden, and Terrell Russell as signatories to docs/backdoors.rst
68zooko@zooko.com**20101015053242
69 Ignore-this: c77adf819d664f673e17c4aaeb353f33
70]
71[docs: convert all .txt docs to .rst thanks to Ravi Pinjala
72zooko@zooko.com**20101015052913
73 Ignore-this: 178a5122423189ecfc45b142314a78ec
74 fixes #1225
75]
76[docs: add statement on our refusal to insert backdoors
77zooko@zooko.com**20101006051147
78 Ignore-this: 644d308319a7b80c4434bdff9760404a
79]
80[setup: add --multi-version to the "setup.py develop" command-line
81zooko@zooko.com**20101005182350
82 Ignore-this: 709155cc21caff29826b8d41a8c8d63d
83 fixes #530. I earlier tried this twice (see #530 for history) and then twice rolled it back due to some problems that arose. However, I didn't write down what the problems were in enough detail on the ticket that I can tell today whether those problems are still issues, so here goes the third attempt. (I did write down on the ticket that it would not create site.py or .pth files in the target directory with --multi-version mode, but I didn't explain why *that* was a problem.)
84]
85[setup: use execfile to access _auto_deps.py in its proper location of src/allmydata/ instead of copying it into place when setup.py is executed
86zooko@zooko.com**20100906055714
87 Ignore-this: c179b42672d775580afad40121f86812
88]
89[trivial: M-x whitespace-cleanup
90zooko@zooko.com**20100903144712
91 Ignore-this: 1bb764d11ac69b4a35ea091cfb13158a
92]
93[minor: remove unused interface declaration, change allmydata.org to tahoe-lafs.org in email address, fix wording in relnotes.txt
94zooko@zooko.com**20100930153708
95 Ignore-this: a452969228afed2774de375e29fa3048
96]
97[immutable/repairer.py: don't use the default happiness setting when repairing
98Kevan Carstensen <kevan@isnotajoke.com>**20100927200102
99 Ignore-this: bd704d9744b970849da8d46a16b8089a
100]
101[NEWS: note dependency updates to pycryptopp and pycrypto.
102david-sarah@jacaranda.org**20100924191207
103 Ignore-this: eeaf5c9c9104f24c450c2ec4482ac1ee
104]
105[TAG allmydata-tahoe-1.8.0
106zooko@zooko.com**20100924021631
107 Ignore-this: 494ca0a885c5e20c883845fc53e7ab5d
108]
109Patch bundle hash:
110f73fa30763c67297b7b9a4f186b63735152ba966