Ticket #1172: downloader-status-1172-2.dpatch

Thu Sep  2 12:17:28 CEST 2010  francois@ctrlaltdel.ch
  * DownloadStatus: show active immutable downloads in Active Operations, Fix #1172

New patches:

[DownloadStatus: show active immutable downloads in Active Operations, Fix #1172
francois@ctrlaltdel.ch**20100902101728
 Ignore-this: 47d2b214bbf6e4713890f0ba4d4beecf
] {
hunk ./src/allmydata/immutable/downloader/status.py 205
 
     def using_helper(self):
         return False
+
     def get_active(self):
hunk ./src/allmydata/immutable/downloader/status.py 207
-        return False # TODO
+        # a download is considered active if it has at least one outstanding
+        # read() call
+        for r_ev in self.read_events:
+            if r_ev["finish_time"] is None:
+                return True
+        return False
+
     def get_started(self):
         return self.started
     def get_results(self):
hunk ./src/allmydata/test/test_download.py 1262
         e2.finished(now+5)
         self.failUnlessEqual(ds.get_progress(), 1.0)
 
+    def test_active(self):
+        now = 12345.1
+        ds = DownloadStatus("si-1", 123)
+        self.failUnlessEqual(ds.get_active(), False)
+        e1 = ds.add_read_event(0, 1000, now)
+        self.failUnlessEqual(ds.get_active(), True)
+        e2 = ds.add_read_event(1, 1000, now+1)
+        self.failUnlessEqual(ds.get_active(), True)
+        e1.finished(now+2)
+        self.failUnlessEqual(ds.get_active(), True)
+        e2.finished(now+3)
+        self.failUnlessEqual(ds.get_active(), False)
+
 class MyShare:
     def __init__(self, shnum, peerid, rtt):
         self._shnum = shnum
}

Context:

[tests: bump up the allowed number of reads
zooko@zooko.com**20100902053801
 Ignore-this: 9450a720c9c5f51d63454029673cca16
 Kyle's OpenBSD buildslave used 41 reads when doing this test. The fact that I'm blindly bumping this number up to match the observed behavior probably means this isn't a good criterion to be testing for anyway. But perhaps someone else (Brian) could investigate why that run on Kyle's OpenBSD box took four more reads than we expected, and whether the fact that it took 41 reads to do this operation is indicative of an actual problem.
] 
[SegmentFetcher: use new diversity-seeking share-selection algorithm, and
"Brian Warner <warner@lothar.com>"**20100901013702
 deliver all shares at once instead of feeding them out one-at-a-time.
 
 Also fix distribution of real-number-of-segments information: now all
 CommonShares (not just the ones used for the first segment) get a
 correctly-sized hashtree. Previously, the late ones might not, which would
 make them crash and get dropped (causing the download to fail if the initial
 set were insufficient, perhaps because one of their servers went away).
 
 Update tests, add some TODO notes, improve variable names and comments.
 Improve logging: add logparents, set more appropriate levels.
 
] 
[Share: drop received data after each block finishes. Quick fix for the #1170 spans.py complexity bug.
"Brian Warner <warner@lothar.com>"**20100901013558] 
[docs: a couple of small edits to CREDITS and how_to_make_a_tahoe-lafs_release.txt
zooko@zooko.com**20100829222758
 Ignore-this: cfdb414f86dfd581b5f1d4d94231b85c
] 
[add simulator to explore the trade-offs for hashed-based digital signatures
zooko@zooko.com**20100819030630
 Ignore-this: 284e6d8b4140d2ecd9a4b14247d0816f
] 
[_auto_deps.py: change pycrypto version requirement to avoid https://bugs.launchpad.net/pycrypto/+bug/620253
david-sarah@jacaranda.org**20100829230038
 Ignore-this: e58f98ef262444067fc4b31fad23e40b
] 
[docs: update NEWS a bit about New-Downloader
zooko@zooko.com**20100819021446
 Ignore-this: 31a6e2fb0a6e3d19f73481e99070da7a
] 
[misc: add benchmarking tool for spans
zooko@zooko.com**20100819021420
 Ignore-this: 569327a1908a07e5fb634526bed515b2
] 
[web: refactor rate computation, fixes #1166
francois@ctrlaltdel.ch**20100815141933
 Ignore-this: d25491858e137894142eaa67c75b0439
] 
[docs: doc of the download status page
zooko@zooko.com**20100814054117
 Ignore-this: a82ec33da3c39a7c0d47a7a6b5f81bbb
 ref: http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1169#comment:1
] 
[docs: NEWS: edit English usage, remove ticket numbers for regressions vs. 1.7.1 that were fixed again before 1.8.0c2
zooko@zooko.com**20100811071758
 Ignore-this: 993f5a1e6a9535f5b7a0bd77b93b66d0
] 
[docs: NEWS: more detail about new-downloader
zooko@zooko.com**20100811071303
 Ignore-this: 9f07da4dce9d794ce165aae287f29a1e
] 
[TAG allmydata-tahoe-1.8.0c2
david-sarah@jacaranda.org**20100810073847
 Ignore-this: c37f732b0e45f9ebfdc2f29c0899aeec
] 
Patch bundle hash:
e38f0fee48232f5d754af3acda81381341e099fb