[tahoe-dev] [tahoe-lafs] #637: support "keep this much disk space free" on Windows as well as other platforms

[tahoe-lafs]

#637: support "keep this much disk space free" on Windows as well as other
platforms
-------------------------------+--------------------------------------------
 Reporter:  zooko              |           Owner:       
     Type:  defect             |          Status:  new  
 Priority:  major              |       Milestone:  1.6.0
Component:  code-storage       |         Version:  1.3.0
 Keywords:  win32 easy review  |   Launchpad_bug:       
-------------------------------+--------------------------------------------

Comment(by davidsarah):

 For _auto_deps.py and the docstrings in server.py, I just followed the
 conventions already used in those files.

 The line endings should indeed be fixed.

 {{{import win32api, win32con}}} also violates PEP 8, although I can't
 actually see the reason for that style constraint.

 Re: error handling -- I assume you mean, why '''don't''' we treat a
 failure in the system call in the same way as not having an API? The
 reason is that not having an API is not an indication that there is
 anything wrong; just that the platform has a limitation that means we
 can't implement space checking.

 If the platform does have the API, OTOH, then we're supposed to be
 enforcing space checking, and an admin may be expecting that we do. So a
 system call failure should be treated as an error in that case, as
 suggested by Zooko in comment:6.

-- 
Ticket URL: <http://allmydata.org/trac/tahoe/ticket/637#comment:25>
tahoe-lafs <http://allmydata.org>
secure decentralized file storage grid