[tahoe-dev] [tahoe-lafs] #778: "shares of happiness" is the wrong measure; "servers of happiness" is better

[tahoe-lafs]

#778: "shares of happiness" is the wrong measure; "servers of happiness" is
better
--------------------------------+-------------------------------------------
 Reporter:  zooko               |           Owner:  kevan
     Type:  defect              |          Status:  new  
 Priority:  critical            |       Milestone:  1.6.0
Component:  code-peerselection  |         Version:  1.4.1
 Keywords:  reliability         |   Launchpad_bug:       
--------------------------------+-------------------------------------------

Comment(by kevan):

 I altered the set_shareholders method in
 [source:src/allmydata/interfaces.py at 4088#L1224 IEncoder] to require a
 {{{servermap}}} argument. {{{servermap}}} is a mapping of shnum to a
 string (the peerid, ideally) that will be storing (whether by result of an
 upload or by result of already having it) a share. This gives the Encoder
 enough information to make an accurate check for
 {{{servers_of_happiness}}} when it loses a peer and (combined with
 modifications to make code that used the Encoder use the new form of
 set_shareholders) also makes the tests pass.

 Comments? Is there anything else in the way of this issue? Is there a
 cleaner way of altering the Encoder to do what I want it to do?

-- 
Ticket URL: <http://allmydata.org/trac/tahoe/ticket/778#comment:69>
tahoe-lafs <http://allmydata.org>
secure decentralized file storage grid